From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3246C07E96 for ; Tue, 6 Jul 2021 13:32:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A24FC61369 for ; Tue, 6 Jul 2021 13:32:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A24FC61369 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0lBL-0004sb-Oo for qemu-devel@archiver.kernel.org; Tue, 06 Jul 2021 09:32:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0l9n-0003Pu-UB for qemu-devel@nongnu.org; Tue, 06 Jul 2021 09:30:37 -0400 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]:40448) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0l9k-0005ZL-K3 for qemu-devel@nongnu.org; Tue, 06 Jul 2021 09:30:35 -0400 Received: by mail-oi1-x22e.google.com with SMTP id l26so21918298oic.7 for ; Tue, 06 Jul 2021 06:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hq98K53qJd88jdd2gUR8XHVXLAPCMF1bS5TpOfnDRP8=; b=onwVf03nas49BfYmDJXWc1WDUFWFLxjv7d//aHCZrytFoHKvkC9mwHgxt9R8SYo+Jk mgaazY+nxRkCWInk/w3Gvu9BlpBtIgrPZ1peWvyb7P+pBFry2HBpkoywydXEwPkDGGTS GWwGFMsFxKUM4yOliVTG0Ss+vbbhuXPdzMvBEMllm81/86hFSi8S/M2IGlhcm2ygI3gr zhheguOsHg5zBVL2bdHbmHCUqk+9heUezqwKTdyl1VwmeGr4pwCWmIKZb6AIG9cEHeg5 HbQdrVfcIk9Kp5GHZwsq6iLkwmAzZyeukclzSUFBJIzyLRCXMZhjSYnEA3YX/RbPBPeZ 8Hiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hq98K53qJd88jdd2gUR8XHVXLAPCMF1bS5TpOfnDRP8=; b=TGM72ZeIMIi33mFRfgIdHzs8HyGeD6gU8eeiWZJUKZq7R+GuuAqZna/NxLwalB5AUL vCJ7D8K0ShNMiwZaEqXdjkZT3om83N9GaQCkVOmCniJ61lylph3l4/+9CLcRFKmk4xeI OKqU5GsctITpkbd5epogomfoOjdhIywulBt0bnYq0JfPsahVxQcoBMiwIZduTnrI/o60 HlYu8Q3I1ebKxut2u0KKofcDy7S0nnC7XF2mrYzF0CMH/bVWGSD8dfS7YG9o/kp2fPuI SNRXjQo7LCrdLjTZtlcEWDZkvZWNEEEsPvplKVbjftqnu8N8iN7x7vs1taLAB9AZwg73 7cYw== X-Gm-Message-State: AOAM531NmT3q9Z75SahlqY6/svOu0gxPx2yt+O58ACkKCPZ6p3wRMvSp A7WYgWGmSnBQm8tZ2cowa9FJIN44HwHLBGFnx54= X-Google-Smtp-Source: ABdhPJxU3tXbRrk3v8bHGd2CAuPa0KHx5u9vCHKM/pUsW6K/IEg+mtC+UemI5tSTrM/ulbuX7nGfnlrclazA74Gt+pU= X-Received: by 2002:aca:d9d7:: with SMTP id q206mr8331055oig.93.1625578230123; Tue, 06 Jul 2021 06:30:30 -0700 (PDT) MIME-Version: 1.0 References: <20210617190739.3673064-1-jusual@redhat.com> In-Reply-To: <20210617190739.3673064-1-jusual@redhat.com> From: Marcel Apfelbaum Date: Tue, 6 Jul 2021 16:30:19 +0300 Message-ID: Subject: Re: [PATCH v5 0/7] Use ACPI PCI hot-plug for Q35 To: Julia Suvorova Content-Type: multipart/alternative; boundary="000000000000f610dc05c6746cd9" Received-SPF: pass client-ip=2607:f8b0:4864:20::22e; envelope-from=marcel.apfelbaum@gmail.com; helo=mail-oi1-x22e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , David Gibson , qemu devel list , Eduardo Habkost , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000f610dc05c6746cd9 Content-Type: text/plain; charset="UTF-8" Hi Julia, On Thu, Jun 17, 2021 at 10:07 PM Julia Suvorova wrote: > The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > I have tested the patches and I noticed 2 issues: 1. The changes allow to hotplug a device into the pcie.0 bus (device_add e1000) - The device can be seen using `info qtree` but is not visible in guest. pcie.0 bus should not support hotplug at all. Before the series we get: Error: Bus 'pcie.0' does not support hotplugging 2. The devices hotplugged into a pcie-root-port are not allocated IO space: device_add e1000,id=e1,bus=rp1 In dmesg I see: [ 24.699178] pci 0000:01:00.0: BAR 1: no space for [io size 0x0040] [ 24.699753] pci 0000:01:00.0: BAR 1: failed to assign [io size 0x0040] And in lspci I see: I/O ports at [disabled] Before the series: I/O ports at 1000 [size=64] Could you please check? Thanks, Marcel --000000000000f610dc05c6746cd9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Julia,

On Thu, Jun 17, 2021 at 10:07 PM= Julia Suvorova <jusual@redhat.com<= /a>> wrote:
T= he patch set consists of two parts:
patches 1-4: introduce new feature
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'acpi-pci-hotplug-with-= bridge-support' on Q35
patches 5-7: make the feature default along with changes in ACPI tables


=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0[=C2=A0 24.699753] pci 0000:01:00.0: BAR 1: failed to assi= gn [io =C2=A0size 0x0040]
=C2=A0 =C2=A0And in lspci I see:
=C2=A0 Before the series:
=C2=A0 =C2=A0 =C2=A0=C2=A0I/O ports at 1000 [= size=3D64]
=C2=A0 =C2=A0=C2=A0

Could you please c= heck?=C2=A0=C2=A0

Thanks,
Marcel
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
--000000000000f610dc05c6746cd9--