From: Vasiliy Tolstov <v.tolstov@selfip.ru>
To: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
Cc: Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>,
Jeff Cody <jcody@redhat.com>,
sheepdog@lists.wpkg.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] sheepdog: use per AIOCB dirty indexes for non overlapping requests
Date: Wed, 2 Sep 2015 15:36:23 +0300 [thread overview]
Message-ID: <CACaajQsn7NupWJsSeHvyKUd7Uzk1euE4h3-_mL2eqHHh3hkaAw@mail.gmail.com> (raw)
In-Reply-To: <1441076590-8015-2-git-send-email-mitake.hitoshi@lab.ntt.co.jp>
2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>:
> n the commit 96b14ff85acf, requests for overlapping areas are
> serialized. However, it cannot handle a case of non overlapping
> requests. In such a case, min_dirty_data_idx and max_dirty_data_idx
> can be overwritten by the requests and invalid inode update can
> happen e.g. a case like create(1, 2) and create(3, 4) are issued in
> parallel.
>
> This patch lets SheepdogAIOCB have dirty data indexes instead of
> BDRVSheepdogState for avoiding the above situation.
>
> This patch also does trivial renaming for better description:
> overwrapping -> overlapping
>
> Cc: Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>
> Cc: Vasiliy Tolstov <v.tolstov@selfip.ru>
> Cc: Jeff Cody <jcody@redhat.com>
> Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
I'm test this patch and now discard working properly and no errors in
sheepdog log file.
Tested-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
--
Vasiliy Tolstov,
e-mail: v.tolstov@selfip.ru
next prev parent reply other threads:[~2015-09-02 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 3:03 [Qemu-devel] [PATCH 0/2] sheepdog driver update Hitoshi Mitake
2015-09-01 3:03 ` [Qemu-devel] [PATCH 1/2] sheepdog: use per AIOCB dirty indexes for non overlapping requests Hitoshi Mitake
2015-09-02 12:36 ` Vasiliy Tolstov [this message]
2015-09-24 2:20 ` [Qemu-devel] [sheepdog] " Hitoshi Mitake
2015-09-01 3:03 ` [Qemu-devel] [PATCH 2/2] sheepdog: refine discard support Hitoshi Mitake
2015-09-02 12:36 ` Vasiliy Tolstov
2015-09-04 8:51 ` [Qemu-devel] [sheepdog] " Hitoshi Mitake
2015-09-04 9:57 ` Hitoshi Mitake
2015-09-04 10:32 ` Vasiliy Tolstov
2015-09-25 14:32 ` [Qemu-devel] [PATCH 0/2] sheepdog driver update Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACaajQsn7NupWJsSeHvyKUd7Uzk1euE4h3-_mL2eqHHh3hkaAw@mail.gmail.com \
--to=v.tolstov@selfip.ru \
--cc=ishizaki.teruaki@lab.ntt.co.jp \
--cc=jcody@redhat.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).