From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60270)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vase@selfip.ru>) id 1ZX7HP-0000Z1-UZ
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 08:36:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vase@selfip.ru>) id 1ZX7HM-0006Wu-Fl
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 08:36:43 -0400
Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:35878)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vase@selfip.ru>) id 1ZX7HM-0006We-3M
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 08:36:40 -0400
Received: by lanb10 with SMTP id b10so5943733lan.3
	for <qemu-devel@nongnu.org>; Wed, 02 Sep 2015 05:36:38 -0700 (PDT)
MIME-Version: 1.0
Sender: vase@selfip.ru
In-Reply-To: <1441076590-8015-2-git-send-email-mitake.hitoshi@lab.ntt.co.jp>
References: <1441076590-8015-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp>
	<1441076590-8015-2-git-send-email-mitake.hitoshi@lab.ntt.co.jp>
From: Vasiliy Tolstov <v.tolstov@selfip.ru>
Date: Wed, 2 Sep 2015 15:36:23 +0300
Message-ID: <CACaajQsn7NupWJsSeHvyKUd7Uzk1euE4h3-_mL2eqHHh3hkaAw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/2] sheepdog: use per AIOCB dirty indexes
 for non overlapping requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
Cc: Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>, Jeff Cody <jcody@redhat.com>, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org

2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>:
> n the commit 96b14ff85acf, requests for overlapping areas are
> serialized. However, it cannot handle a case of non overlapping
> requests. In such a case, min_dirty_data_idx and max_dirty_data_idx
> can be overwritten by the requests and invalid inode update can
> happen e.g. a case like create(1, 2) and create(3, 4) are issued in
> parallel.
>
> This patch lets SheepdogAIOCB have dirty data indexes instead of
> BDRVSheepdogState for avoiding the above situation.
>
> This patch also does trivial renaming for better description:
> overwrapping -> overlapping
>
> Cc: Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>
> Cc: Vasiliy Tolstov <v.tolstov@selfip.ru>
> Cc: Jeff Cody <jcody@redhat.com>
> Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>

I'm test this patch and now discard working properly and no errors in
sheepdog log file.

Tested-by: Vasiliy Tolstov <v.tolstov@selfip.ru>

-- 
Vasiliy Tolstov,
e-mail: v.tolstov@selfip.ru