From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX7Hm-0000y3-72 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 08:37:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX7Hi-0006pE-N6 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 08:37:06 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:33989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX7Hi-0006mm-AJ for qemu-devel@nongnu.org; Wed, 02 Sep 2015 08:37:02 -0400 Received: by laeb10 with SMTP id b10so6067624lae.1 for ; Wed, 02 Sep 2015 05:37:01 -0700 (PDT) MIME-Version: 1.0 Sender: vase@selfip.ru In-Reply-To: <1441076590-8015-3-git-send-email-mitake.hitoshi@lab.ntt.co.jp> References: <1441076590-8015-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp> <1441076590-8015-3-git-send-email-mitake.hitoshi@lab.ntt.co.jp> From: Vasiliy Tolstov Date: Wed, 2 Sep 2015 15:36:46 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 2/2] sheepdog: refine discard support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hitoshi Mitake Cc: Teruaki Ishizaki , Jeff Cody , sheepdog@lists.wpkg.org, qemu-devel@nongnu.org 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake : > This patch refines discard support of the sheepdog driver. The > existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which > was introduced before fine grained reference counting on newer > sheepdog. It doesn't care about relations of snapshots and clones and > discards objects unconditionally. > > With this patch, the driver just updates an inode object for updating > reference. Removing the object is done in sheep process side. > > Cc: Teruaki Ishizaki > Cc: Vasiliy Tolstov > Cc: Jeff Cody > Signed-off-by: Hitoshi Mitake I'm test this patch and now discard working properly and no errors in sheepdog log file. Tested-by: Vasiliy Tolstov -- Vasiliy Tolstov, e-mail: v.tolstov@selfip.ru