qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Turner <digit@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] Fix libvhost-user.c compilation.
Date: Fri, 7 Apr 2023 11:49:30 +0200	[thread overview]
Message-ID: <CACnJMqokdhkE5F_nDUtbAUWa8Fs8NBO1Ns0SvyPf58YsUJAfeQ@mail.gmail.com> (raw)
In-Reply-To: <20230407054455-mutt-send-email-mst@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On Fri, Apr 7, 2023 at 11:46 AM Michael S. Tsirkin <mst@redhat.com> wrote:

> On Fri, Apr 07, 2023 at 11:29:46AM +0200, David Turner wrote:
> > So it looks like that for some reason, the QEMU linux-headers directory
> is not
> > in the include search path for this compilation command, and that the
> > system-or-sysroot provided <linux/vhost.h> is picked instead. Fixing
> this might
> > be a better long-term fix than what I am proposing in this patch. I am
> not sure
> > how to do that yet though. Do you have any recommendations?
>
> Check what flags are passed to the compiler :)
>

That's what I did :-)

meson.build has:
>
> if targetos == 'linux'
>   add_project_arguments('-isystem', meson.current_source_dir() /
> 'linux-headers',
>                         '-isystem', 'linux-headers',
>                         language: all_languages)
> endif
>
> add_project_arguments() does not apply the arguments to subprojects, hence
why this fails for subprojects/libvhost-user /


> --
> MST
>
>

[-- Attachment #2: Type: text/html, Size: 1770 bytes --]

  reply	other threads:[~2023-04-07  9:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 17:21 [PATCH v2] Fix QEMU compilation on Debian 10 David 'Digit' Turner
2023-04-05 17:21 ` [PATCH 1/3] Fix libvhost-user.c compilation David 'Digit' Turner
2023-04-07  8:03   ` Michael S. Tsirkin
2023-04-07  9:24     ` David Turner
2023-04-07  9:25       ` David Turner
2023-04-07  9:29         ` David Turner
2023-04-07  9:46           ` Michael S. Tsirkin
2023-04-07  9:49             ` David Turner [this message]
2023-04-07  9:47           ` David Turner
2023-04-07 10:01             ` Michael S. Tsirkin
2023-04-18  8:47         ` Daniel P. Berrangé
2023-04-18 11:04           ` David Turner
2023-04-18 11:47   ` Michael S. Tsirkin
2023-04-05 17:21 ` [PATCH 2/3] update-linux-headers.sh: Add missing kernel headers David 'Digit' Turner
2023-04-05 17:21 ` [PATCH 3/3] Update linux headers to v6.3rc5 David 'Digit' Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACnJMqokdhkE5F_nDUtbAUWa8Fs8NBO1Ns0SvyPf58YsUJAfeQ@mail.gmail.com \
    --to=digit@google.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).