Re: [PATCH 2/2] Add missing Linux kernel headers.

[David Turner <digit@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]

On Wed, Apr 5, 2023 at 3:06 PM Cornelia Huck <cohuck@redhat.com> wrote:

> On Wed, Apr 05 2023, "David 'Digit' Turner" <digit@google.com> wrote:
>
> > Add <linux/memfd.h>, used by hw/display/virtio-gpu-udmabuf.c
> > Add <linux/nvme_ioctl.h>, used by qga/commands-posix.c
> > Add <linux/const.h> used by kvm-all.c, which requires
> > the _BITUL() macro definition to be available.
> >
> > Without these, QEMU will not compile on Debian 10 systems.
>
> Hm, I wonder why we hadn't seen errors in the CI then.
>

No idea either, but fwiw, I am building on a docker.io/debian:10-slim
container.

>
> > The script has then been run against the official
> > 6.2.8 kernel source tree (current stable release),
> > which explains why comments in <linux/vfio.h>
> > have been updated too.
>
> I think we usually run the script against a release or release
> candidate, not stable.
>
> I meant that this was run against the headers of the 6.2.8 official
release, which was listed as "stable" on https://kernel.org/ (that page now
lists the 6.2.9 release btw)
I'd be happy to re-run it against a different set if you can tell me which
one (and where to get it, just in case).

>
> > Signed-off-by: David 'Digit' Turner <digit@google.com>
> > ---
> >  linux-headers/linux/const.h      |  36 ++++++++++
> >  linux-headers/linux/memfd.h      |  35 ++++++++++
> >  linux-headers/linux/nvme_ioctl.h | 114 +++++++++++++++++++++++++++++++
> >  linux-headers/linux/vfio.h       |  15 ++--
> >  scripts/update-linux-headers.sh  |   4 +-
> >  5 files changed, 196 insertions(+), 8 deletions(-)
> >  create mode 100644 linux-headers/linux/const.h
> >  create mode 100644 linux-headers/linux/memfd.h
> >  create mode 100644 linux-headers/linux/nvme_ioctl.h
>
>

[-- Attachment #2: Type: text/html, Size: 2833 bytes --]