From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tamlokveer@gmail.com>) id 1XHtb4-0005lr-1b
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:53:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tamlokveer@gmail.com>) id 1XHtb3-0002UB-6k
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:53:34 -0400
Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:34032)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tamlokveer@gmail.com>) id 1XHtb3-0002U5-1S
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:53:33 -0400
Received: by mail-qg0-f48.google.com with SMTP id i50so906724qgf.35
	for <qemu-devel@nongnu.org>; Thu, 14 Aug 2014 04:53:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <53ECA2AB.6060907@web.de>
References: <1407740702-4086-1-git-send-email-tamlokveer@gmail.com>
	<1407740702-4086-4-git-send-email-tamlokveer@gmail.com>
	<20140814110652.GQ31346@redhat.com> <53EC9F51.7050304@web.de>
	<20140814114304.GA24157@redhat.com> <53ECA2AB.6060907@web.de>
Date: Thu, 14 Aug 2014 19:53:32 +0800
Message-ID: <CACrq+iKBriRHEHxPFUAX_t574PVMycrFHWpLDC5rPHFZ1Y8MOw@mail.gmail.com>
From: Le Tan <tamlokveer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI
	tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Stefan Weil <sw@weilnetz.de>, Knut Omang <knut.omang@oracle.com>, qemu-devel <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>

2014-08-14 19:51 GMT+08:00 Jan Kiszka <jan.kiszka@web.de>:
> On 2014-08-14 13:43, Michael S. Tsirkin wrote:
>> On Thu, Aug 14, 2014 at 01:36:49PM +0200, Jan Kiszka wrote:
>>> On 2014-08-14 13:06, Michael S. Tsirkin wrote:
>>>> On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote:
>>>>> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE exists,
>>>>> add DMAR table to ACPI RSDT table. For now the DMAR table indicates that there
>>>>> is only one hardware unit without INTR_REMAP capability on the platform.
>>>>>
>>>>> Signed-off-by: Le Tan <tamlokveer@gmail.com>
>>>>
>>>> Could you add a unit test please?
>>>
>>> While unit tests would really be helpful, I'm afraid that's not in reach
>>> (GSoC is almost over). The good news is that we have pretty broad test
>>> coverage with both Linux and also Jailhouse already.
>>>
>>> Do you see unit tests as precondition for merging the series?
>>>
>>> Jan
>>>
>>
>> Not a pre-requisite - it's very easy to add a unit test,
>> just add a case in test_acpi_tcg. So I can do it myself afterwards.
>>
>
> Ah, ok, that's tests/bios-tables-test.c. Maybe Le can have a look if
> time is left. But hard pecils-down is already on the 18th.
>
> Jan
>
>

OK, I will attempt to add that. I have just pushed the IOTLB cache. I
am going to fix patches according to these reviews now.

Le