From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 101A4C636D4 for ; Wed, 15 Feb 2023 15:11:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSJQe-0005ye-6b; Wed, 15 Feb 2023 10:10:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSJQb-0005vL-TQ for qemu-devel@nongnu.org; Wed, 15 Feb 2023 10:10:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSJQa-00016o-2w for qemu-devel@nongnu.org; Wed, 15 Feb 2023 10:10:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676473834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oIm776lWihosTy4EFUGfX+CnOeDzc8aDYNHtpNY64ZY=; b=WPOiASvvU0/veLX8/G8Qu0nVc1rwqkTbgFPxwgiPIno17YQIKCykMyiGMltV6SPdfJ4JWp sunzBPJVYBrj6J046tCBVBC1B+2l11sZWisplip2LswEf45J7VIeq4X6KfrPoOq7tom7oX PGbEpZUNSU48O+XphAti6gTINy/43Wg= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-139-uCJKFUnNO-2BdM00zq5PaA-1; Wed, 15 Feb 2023 10:10:15 -0500 X-MC-Unique: uCJKFUnNO-2BdM00zq5PaA-1 Received: by mail-qt1-f198.google.com with SMTP id v3-20020a05622a188300b003ba183e8272so11251949qtc.0 for ; Wed, 15 Feb 2023 07:10:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676473811; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oIm776lWihosTy4EFUGfX+CnOeDzc8aDYNHtpNY64ZY=; b=mvLTvHl9ZFLNR36+nAR3mqsmf08Ss3WCKKH32xFSoHc3eo6hKthb36IGRviJQ3DMMG YmGl5e+bsfzH9KmHWxvVXFe6/Tko1zDY+nLXdlfUMQ8XLeBcU5/W2iTed8y6w0folTDp RGLTar4oPXzl3/Ulf/2tlJjm6s7UygBE4Y1jW1qWsiB+C7YEQMea1c5EhF9i2lVIgVmp 8kr/dQ7eacRUl29+elnHQIKdNAzcXBuFkrV5d/oY7zmgXJ9mGRv97Z9v8vZlsgohtEmF YutWhsIHI7lGg1Y8E+slPoGSSb08dgUBoS2nU9CY7xyoCfIt3PUVbWpwdEQqVrT7P/JR dm1Q== X-Gm-Message-State: AO0yUKVU2A4gpan9ZjlknkcsvruoyAAjwbEOTsqEmHnwMF8TsnD2jaMk R1bcwCJYob3EQEZczfBVAX95C/f1Y0+YHVSHkBoNffduPZLPjYiQLW/h9vb+ky6E6HmUsQO22fx QUJNj9apzRengfThTUxg+827WcAwu4mg= X-Received: by 2002:a0c:cb0c:0:b0:56e:bf84:ccd9 with SMTP id o12-20020a0ccb0c000000b0056ebf84ccd9mr174336qvk.12.1676473810767; Wed, 15 Feb 2023 07:10:10 -0800 (PST) X-Google-Smtp-Source: AK7set9dH2/JmMP6CWbhBSTsnNou30QOmD0anjwGkVxgV3+d6ipM4asrBDhDCqEZTvnfiV07dFaQ7IDo/kIRFXmcrdk= X-Received: by 2002:a0c:cb0c:0:b0:56e:bf84:ccd9 with SMTP id o12-20020a0ccb0c000000b0056ebf84ccd9mr174330qvk.12.1676473810521; Wed, 15 Feb 2023 07:10:10 -0800 (PST) MIME-Version: 1.0 References: <20230215085102.415053-1-dbassey@redhat.com> <5159868.WgR6L5i3FV@silver> In-Reply-To: From: Dorinda Bassey Date: Wed, 15 Feb 2023 16:09:59 +0100 Message-ID: Subject: Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: Christian Schoenebeck , qemu-devel@nongnu.org, kraxel@redhat.com, armbru@redhat.com, pbonzini@redhat.com, wtaymans@redhat.com Content-Type: multipart/alternative; boundary="000000000000f3a7bd05f4be790a" Received-SPF: pass client-ip=170.10.129.124; envelope-from=dbassey@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --000000000000f3a7bd05f4be790a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > My point is that pipewire has ALSA plugin (and also pulseaudio compat > library etc). So why add another back in QEMU? > Good question. Well the pulseaudio compatibility layer adds to the runtime overhead and dependency, dropping the usage of pw-pulse daemon as a runtime dependency would reduce footprint. For ALSA, it's a native layer and you do not want clients talking to ALSA directly if they need to share resources with other processes. Regards, Dorinda. On Wed, Feb 15, 2023 at 3:11 PM Marc-Andr=C3=A9 Lureau < marcandre.lureau@gmail.com> wrote: > Hi > > On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck > wrote: > > > > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-Andr=C3=A9 Lureau w= rote: > > > Hi > > > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey > wrote: > > > > > > > > This commit adds a new audiodev backend to allow QEMU to use > Pipewire as > > both an audio sink and source. This backend is available on most system= s. > > > > > > > > > > Hmm, I would rather have less audio (and ui) backends in QEMU. (for > > > audio, if I could introduce and keep only one, that would be > > > GStreamer: to remove the others..) > > > > > > What is the main advantage compared to using the ALSA backend? (I > > > assume pipewire depends on ALSA anyway on Linux) > > > > I think it does make sense to add Pipewire. Apparently it gains > popularity. > > My point is that pipewire has ALSA plugin (and also pulseaudio compat > library etc). So why add another back in QEMU? > > > The main advantage of Pipewire is its interoperability: It allows you t= o > > connect apps with each other that only support a specific audio system. > Say > > one app that only supports JACK, another app that only supports > PulseAudio, > > another that only supports ALSA and so on. So it tries to provide a > universal > > plug on a system for all. > > > > Best regards, > > Christian Schoenebeck > > > > > > > -- > Marc-Andr=C3=A9 Lureau > > --000000000000f3a7bd05f4be790a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
My = point is that pipewire has ALSA plugin (and also pulseaudio compat
library etc). So why add another back in QEMU?
Good = question. Well the pulseaudio compatibility layer adds to the runtime overh= ead and dependency, dropping the usage of pw-pulse daemon as a runtime depe= ndency would reduce footprint. For ALSA, it's a native layer and you do= not want clients talking to ALSA directly if they need to share resources = with other processes.

Regards,
Dori= nda.

On Wed, Feb 15, 2023 at 3:11 PM Marc-Andr=C3=A9 Lureau <= marcandre.l= ureau@gmail.com> wrote:
Hi

On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck
<qemu_oss@cr= udebyte.com> wrote:
>
> On Wednesday, February 15, 2023 2:18:50 PM CET Marc-Andr=C3=A9 Lureau = wrote:
> > Hi
> >
> > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey <dbassey@redhat.com> wrote= :
> > >
> > > This commit adds a new audiodev backend to allow QEMU to use= Pipewire as
> both an audio sink and source. This backend is available on most syste= ms.
> > >
> >
> > Hmm, I would rather have less audio (and ui) backends in QEMU. (f= or
> > audio, if I could introduce and keep only one, that would be
> > GStreamer: to remove the others..)
> >
> > What is the main advantage compared to using the ALSA backend? (I=
> > assume pipewire depends on ALSA anyway on Linux)
>
> I think it does make sense to add Pipewire. Apparently it gains popula= rity.

My point is that pipewire has ALSA plugin (and also pulseaudio compat
library etc). So why add another back in QEMU?

> The main advantage of Pipewire is its interoperability: It allows you = to
> connect apps with each other that only support a specific audio system= . Say
> one app that only supports JACK, another app that only supports PulseA= udio,
> another that only supports ALSA and so on. So it tries to provide a un= iversal
> plug on a system for all.
>
> Best regards,
> Christian Schoenebeck
>
>


--
Marc-Andr=C3=A9 Lureau

--000000000000f3a7bd05f4be790a--