From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEC6C83000 for ; Wed, 29 Apr 2020 21:29:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D811B2076B for ; Wed, 29 Apr 2020 21:29:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F6DnsK6u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D811B2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTuGU-00063K-U1 for qemu-devel@archiver.kernel.org; Wed, 29 Apr 2020 17:29:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60160) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTuBW-00040a-Be for qemu-devel@nongnu.org; Wed, 29 Apr 2020 17:28:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTuAF-0002C5-GW for qemu-devel@nongnu.org; Wed, 29 Apr 2020 17:24:02 -0400 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]:44967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTuAF-0002BP-2W for qemu-devel@nongnu.org; Wed, 29 Apr 2020 17:22:43 -0400 Received: by mail-yb1-xb44.google.com with SMTP id o139so2022323ybc.11 for ; Wed, 29 Apr 2020 14:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=E2cqTwkAVjxmv3V2Yhs9fijcUpvzGzF+6McpCZdUFFQ=; b=F6DnsK6unD0hjzbRxAvyETFxb3KjO347uVtOPaCvgC9tyhqxIQtWceTux/rgWVb/v3 9hF5vqqibcJ7WEPbavXevXUg0VRQEoanTnKczE8Kd8Ee3pdoBHs1I0YVAYHV4BUw+Ujq H8yxvrTK7tCBNXlVVaJRQc/3/6LUjz7+tq00NeSZhT+jBl/A7m76Ef76/4E6c9WiCoNV nKM/KhUxVOGkPHYanwsHmnKO+s3oAG5KeBAbZR2wAy1JF2t6jtqCjJmL3l87cK2P/a2T UZqM7Tq3dIFrMR0otOQpWO1o1qWfxqYIV+2xLqcDhbxP8BgL3NJgLbzqFuv8ns6TuZPm 6M9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=E2cqTwkAVjxmv3V2Yhs9fijcUpvzGzF+6McpCZdUFFQ=; b=AL07rXi8rkt1jW1FnIOrIQh1q/MjqUF02eI11JTOY2b4TIg+vLu0BKL6XX5tKCNnvy P2iEmjHadgIBNShx6PiSNr1KvjTgB/4+l8VuCRJ6yZ/UyCxXSBh3sNTko1s5zrUJTXk2 CCNX47M/zBWj/ihjq279aUE6aQVoDr+X0ACXDS+cYX3gqDEJig2uXR8yveFM7XaYRwln gS8pG9s60sWXtbfQ0aaO/88yxsx9LODRNBuo3ew3HAvhuOAMsqvcWnPCCuevP+QuUccW nqaquy11Zsp/Rnc/2bFhXcgk0chKBG0e1OlP8PtheeFQlu1YF2qg49XhNU0mjQDBJOm4 H2ww== X-Gm-Message-State: AGi0PuZIrQy1qEbMf1V2lwvM/AOeHdzAoAyvdbDAFHWqek2Brl/fZCMc oELAOMQM0Ph/YqCEGpNueN2aPxIkKuQ+yTYCu1RBOmVQArw= X-Google-Smtp-Source: APiQypJOUsPkpvbkt+48/Bo/H5VcZQvrHfxSW4TZBbhvAYQZfoUnaHFPxuaCmYgK+nghDdO0Td3CBHqyPg8s+M/q9Ds= X-Received: by 2002:a25:6404:: with SMTP id y4mr501880ybb.374.1588195361162; Wed, 29 Apr 2020 14:22:41 -0700 (PDT) MIME-Version: 1.0 References: <20200422130724.3581-1-maxim.uvarov@linaro.org> In-Reply-To: <20200422130724.3581-1-maxim.uvarov@linaro.org> From: Maxim Uvarov Date: Thu, 30 Apr 2020 00:22:30 +0300 Message-ID: Subject: Re: [PATCHv2] add optee dts entry for secure machine To: qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b44; envelope-from=maxim.uvarov@linaro.org; helo=mail-yb1-xb44.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::b44 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Kindly ping to merge this patch. For more detail. This patch creates a dtb entry to load the optee driver which is needed for secure boot (atf+optee+uboot+linux). Kernel part is already there: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tee/optee/core.c?h=v5.7-rc3#n705 .compatible = "linaro,optee-tz" Thank you, Maxim. On Wed, 22 Apr 2020 at 16:07, Maxim Uvarov wrote: > > Add optee compatible string for dtb to force linux > to boot optee module. > > Signed-off-by: Maxim Uvarov > --- > v2: added method. > hw/arm/virt.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 656b008..c937a82 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1335,6 +1335,23 @@ static void create_platform_bus(VirtMachineState *vms) > sysbus_mmio_get_region(s, 0)); > } > > +static void create_secure_tee(VirtMachineState *vms) > +{ > + char *firmware; > + char *optee; > + > + firmware = g_strdup_printf("/firmware"); > + qemu_fdt_add_subnode(vms->fdt, firmware); > + > + optee = g_strdup_printf("/firmware/optee"); > + qemu_fdt_add_subnode(vms->fdt, optee); > + qemu_fdt_setprop_string(vms->fdt, optee, "compatible", "linaro,optee-tz"); > + qemu_fdt_setprop_string(vms->fdt, optee, "method", "smc"); > + > + g_free(optee); > + g_free(firmware); > +} > + > static void create_secure_ram(VirtMachineState *vms, > MemoryRegion *secure_sysmem) > { > @@ -1720,6 +1737,7 @@ static void machvirt_init(MachineState *machine) > if (vms->secure) { > create_secure_ram(vms, secure_sysmem); > create_uart(vms, VIRT_SECURE_UART, secure_sysmem, serial_hd(1)); > + create_secure_tee(vms); > } > > vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64); > -- > 2.17.1 >