* [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id
@ 2022-06-13 10:44 Li Zhang
2022-06-13 14:19 ` Igor Mammedov
0 siblings, 1 reply; 5+ messages in thread
From: Li Zhang @ 2022-06-13 10:44 UTC (permalink / raw)
To: imammedo, marcel.apfelbaum, f4bug, wangyanan55, qemu-devel,
zhlcindy
Cc: Li Zhang
When no memory backend is specified in machine options,
a default memory device will be added with default_ram_id.
However, if a memory backend object is added in QEMU options
and id is the same as default_ram_id, a coredump happens.
Command line:
qemu-system-x86_64 -name guest=vmtest,debug-threads=on \
-machine pc-q35-6.0,accel=kvm,usb=off,vmport=off \
-smp 16,sockets=16,cores=1,threads=1 \
-m 4G \
-object memory-backend-ram,id=pc.ram,size=4G \
-no-user-config -nodefaults -nographic
Stack trace of thread 16903:
#0 0x00007fb109a9318b raise (libc.so.6 + 0x3a18b)
#1 0x00007fb109a94585 abort (libc.so.6 + 0x3b585)
#2 0x0000558c34bc89be error_handle_fatal (qemu-system-x86_64 + 0x9c89be)
#3 0x0000558c34bc8aee error_setv (qemu-system-x86_64 + 0x9c8aee)
#4 0x0000558c34bc8ccf error_setg_internal (qemu-system-x86_64 + 0x9c8ccf)
#5 0x0000558c349f6899 object_property_try_add (qemu-system-x86_64 + 0x7f6899)
#6 0x0000558c349f7df8 object_property_try_add_child (qemu-system-x86_64 + 0x7f7df8)
#7 0x0000558c349f7e91 object_property_add_child (qemu-system-x86_64 + 0x7f7e91)
#8 0x0000558c3454686d create_default_memdev (qemu-system-x86_64 + 0x34686d)
#9 0x0000558c34546f58 qemu_init_board (qemu-system-x86_64 + 0x346f58)
#10 0x0000558c345471b9 qmp_x_exit_preconfig (qemu-system-x86_64 + 0x3471b9)
#11 0x0000558c345497d9 qemu_init (qemu-system-x86_64 + 0x3497d9)
#12 0x0000558c344e54c2 main (qemu-system-x86_64 + 0x2e54c2)
#13 0x00007fb109a7e34d __libc_start_main (libc.so.6 + 0x2534d)
#14 0x0000558c344e53ba _start (qemu-system-x86_64 + 0x2e53ba)
Signed-off-by: Li Zhang <lizhang@suse.de>
---
hw/core/machine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index a673302cce..9ede63b01c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1265,9 +1265,21 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
static bool create_default_memdev(MachineState *ms, const char *path, Error **errp)
{
Object *obj;
+ ObjectProperty *prop;
MachineClass *mc = MACHINE_GET_CLASS(ms);
bool r = false;
+ prop = object_property_find(object_get_objects_root(), mc->default_ram_id);
+ if (prop) {
+ error_report("A memory backend with id '%s' already exists, "
+ "cannot create default RAM backend with the same id. "
+ "Either change id of the offending backend or "
+ "provide system RAM backend explicitly using "
+ "'-machine memory-backend' option. " ,
+ mc->default_ram_id);
+ exit(EXIT_FAILURE);
+ }
+
obj = object_new(path ? TYPE_MEMORY_BACKEND_FILE : TYPE_MEMORY_BACKEND_RAM);
if (path) {
if (!object_property_set_str(obj, "mem-path", path, errp)) {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id
2022-06-13 10:44 [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id Li Zhang
@ 2022-06-13 14:19 ` Igor Mammedov
2022-06-13 14:37 ` Li Zhang
0 siblings, 1 reply; 5+ messages in thread
From: Igor Mammedov @ 2022-06-13 14:19 UTC (permalink / raw)
To: Li Zhang
Cc: marcel.apfelbaum, f4bug, wangyanan55, qemu-devel, zhlcindy,
David Hildenbrand
On Mon, 13 Jun 2022 12:44:02 +0200
Li Zhang <lizhang@suse.de> wrote:
> When no memory backend is specified in machine options,
> a default memory device will be added with default_ram_id.
> However, if a memory backend object is added in QEMU options
> and id is the same as default_ram_id, a coredump happens.
>
> Command line:
> qemu-system-x86_64 -name guest=vmtest,debug-threads=on \
> -machine pc-q35-6.0,accel=kvm,usb=off,vmport=off \
> -smp 16,sockets=16,cores=1,threads=1 \
> -m 4G \
> -object memory-backend-ram,id=pc.ram,size=4G \
> -no-user-config -nodefaults -nographic
>
> Stack trace of thread 16903:
> #0 0x00007fb109a9318b raise (libc.so.6 + 0x3a18b)
> #1 0x00007fb109a94585 abort (libc.so.6 + 0x3b585)
> #2 0x0000558c34bc89be error_handle_fatal (qemu-system-x86_64 + 0x9c89be)
> #3 0x0000558c34bc8aee error_setv (qemu-system-x86_64 + 0x9c8aee)
> #4 0x0000558c34bc8ccf error_setg_internal (qemu-system-x86_64 + 0x9c8ccf)
> #5 0x0000558c349f6899 object_property_try_add (qemu-system-x86_64 + 0x7f6899)
> #6 0x0000558c349f7df8 object_property_try_add_child (qemu-system-x86_64 + 0x7f7df8)
> #7 0x0000558c349f7e91 object_property_add_child (qemu-system-x86_64 + 0x7f7e91)
> #8 0x0000558c3454686d create_default_memdev (qemu-system-x86_64 + 0x34686d)
> #9 0x0000558c34546f58 qemu_init_board (qemu-system-x86_64 + 0x346f58)
> #10 0x0000558c345471b9 qmp_x_exit_preconfig (qemu-system-x86_64 + 0x3471b9)
> #11 0x0000558c345497d9 qemu_init (qemu-system-x86_64 + 0x3497d9)
> #12 0x0000558c344e54c2 main (qemu-system-x86_64 + 0x2e54c2)
> #13 0x00007fb109a7e34d __libc_start_main (libc.so.6 + 0x2534d)
> #14 0x0000558c344e53ba _start (qemu-system-x86_64 + 0x2e53ba)
>
> Signed-off-by: Li Zhang <lizhang@suse.de>
Acked-by: Igor Mammedov <imammedo@redhat.com>
CCing David as he probably would be the one to merge it
> ---
> hw/core/machine.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index a673302cce..9ede63b01c 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -1265,9 +1265,21 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
> static bool create_default_memdev(MachineState *ms, const char *path, Error **errp)
> {
> Object *obj;
> + ObjectProperty *prop;
> MachineClass *mc = MACHINE_GET_CLASS(ms);
> bool r = false;
>
> + prop = object_property_find(object_get_objects_root(), mc->default_ram_id);
> + if (prop) {
> + error_report("A memory backend with id '%s' already exists, "
> + "cannot create default RAM backend with the same id. "
> + "Either change id of the offending backend or "
> + "provide system RAM backend explicitly using "
> + "'-machine memory-backend' option. " ,
> + mc->default_ram_id);
> + exit(EXIT_FAILURE);
> + }
> +
> obj = object_new(path ? TYPE_MEMORY_BACKEND_FILE : TYPE_MEMORY_BACKEND_RAM);
> if (path) {
> if (!object_property_set_str(obj, "mem-path", path, errp)) {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id
2022-06-13 14:19 ` Igor Mammedov
@ 2022-06-13 14:37 ` Li Zhang
2022-06-13 15:31 ` David Hildenbrand
0 siblings, 1 reply; 5+ messages in thread
From: Li Zhang @ 2022-06-13 14:37 UTC (permalink / raw)
To: Igor Mammedov
Cc: Li Zhang, Marcel Apfelbaum, Philippe Mathieu-Daudé,
Yanan Wang, QEMU, David Hildenbrand
On Mon, Jun 13, 2022 at 4:19 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Mon, 13 Jun 2022 12:44:02 +0200
> Li Zhang <lizhang@suse.de> wrote:
>
> > When no memory backend is specified in machine options,
> > a default memory device will be added with default_ram_id.
> > However, if a memory backend object is added in QEMU options
> > and id is the same as default_ram_id, a coredump happens.
> >
> > Command line:
> > qemu-system-x86_64 -name guest=vmtest,debug-threads=on \
> > -machine pc-q35-6.0,accel=kvm,usb=off,vmport=off \
> > -smp 16,sockets=16,cores=1,threads=1 \
> > -m 4G \
> > -object memory-backend-ram,id=pc.ram,size=4G \
> > -no-user-config -nodefaults -nographic
> >
> > Stack trace of thread 16903:
> > #0 0x00007fb109a9318b raise (libc.so.6 + 0x3a18b)
> > #1 0x00007fb109a94585 abort (libc.so.6 + 0x3b585)
> > #2 0x0000558c34bc89be error_handle_fatal (qemu-system-x86_64 + 0x9c89be)
> > #3 0x0000558c34bc8aee error_setv (qemu-system-x86_64 + 0x9c8aee)
> > #4 0x0000558c34bc8ccf error_setg_internal (qemu-system-x86_64 + 0x9c8ccf)
> > #5 0x0000558c349f6899 object_property_try_add (qemu-system-x86_64 + 0x7f6899)
> > #6 0x0000558c349f7df8 object_property_try_add_child (qemu-system-x86_64 + 0x7f7df8)
> > #7 0x0000558c349f7e91 object_property_add_child (qemu-system-x86_64 + 0x7f7e91)
> > #8 0x0000558c3454686d create_default_memdev (qemu-system-x86_64 + 0x34686d)
> > #9 0x0000558c34546f58 qemu_init_board (qemu-system-x86_64 + 0x346f58)
> > #10 0x0000558c345471b9 qmp_x_exit_preconfig (qemu-system-x86_64 + 0x3471b9)
> > #11 0x0000558c345497d9 qemu_init (qemu-system-x86_64 + 0x3497d9)
> > #12 0x0000558c344e54c2 main (qemu-system-x86_64 + 0x2e54c2)
> > #13 0x00007fb109a7e34d __libc_start_main (libc.so.6 + 0x2534d)
> > #14 0x0000558c344e53ba _start (qemu-system-x86_64 + 0x2e53ba)
> >
> > Signed-off-by: Li Zhang <lizhang@suse.de>
>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
>
>
> CCing David as he probably would be the one to merge it
>
Thanks for your review.
> > ---
> > hw/core/machine.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index a673302cce..9ede63b01c 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -1265,9 +1265,21 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
> > static bool create_default_memdev(MachineState *ms, const char *path, Error **errp)
> > {
> > Object *obj;
> > + ObjectProperty *prop;
> > MachineClass *mc = MACHINE_GET_CLASS(ms);
> > bool r = false;
> >
> > + prop = object_property_find(object_get_objects_root(), mc->default_ram_id);
> > + if (prop) {
> > + error_report("A memory backend with id '%s' already exists, "
> > + "cannot create default RAM backend with the same id. "
> > + "Either change id of the offending backend or "
> > + "provide system RAM backend explicitly using "
> > + "'-machine memory-backend' option. " ,
> > + mc->default_ram_id);
> > + exit(EXIT_FAILURE);
> > + }
> > +
> > obj = object_new(path ? TYPE_MEMORY_BACKEND_FILE : TYPE_MEMORY_BACKEND_RAM);
> > if (path) {
> > if (!object_property_set_str(obj, "mem-path", path, errp)) {
>
--
Best Regards
-Li
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id
2022-06-13 14:37 ` Li Zhang
@ 2022-06-13 15:31 ` David Hildenbrand
2022-06-20 12:09 ` Li Zhang
0 siblings, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2022-06-13 15:31 UTC (permalink / raw)
To: Li Zhang, Igor Mammedov
Cc: Li Zhang, Marcel Apfelbaum, Philippe Mathieu-Daudé,
Yanan Wang, QEMU, Paolo Bonzini
On 13.06.22 16:37, Li Zhang wrote:
> On Mon, Jun 13, 2022 at 4:19 PM Igor Mammedov <imammedo@redhat.com> wrote:
>>
>> On Mon, 13 Jun 2022 12:44:02 +0200
>> Li Zhang <lizhang@suse.de> wrote:
>>
>>> When no memory backend is specified in machine options,
>>> a default memory device will be added with default_ram_id.
>>> However, if a memory backend object is added in QEMU options
>>> and id is the same as default_ram_id, a coredump happens.
>>>
>>> Command line:
>>> qemu-system-x86_64 -name guest=vmtest,debug-threads=on \
>>> -machine pc-q35-6.0,accel=kvm,usb=off,vmport=off \
>>> -smp 16,sockets=16,cores=1,threads=1 \
>>> -m 4G \
>>> -object memory-backend-ram,id=pc.ram,size=4G \
>>> -no-user-config -nodefaults -nographic
>>>
>>> Stack trace of thread 16903:
>>> #0 0x00007fb109a9318b raise (libc.so.6 + 0x3a18b)
>>> #1 0x00007fb109a94585 abort (libc.so.6 + 0x3b585)
>>> #2 0x0000558c34bc89be error_handle_fatal (qemu-system-x86_64 + 0x9c89be)
>>> #3 0x0000558c34bc8aee error_setv (qemu-system-x86_64 + 0x9c8aee)
>>> #4 0x0000558c34bc8ccf error_setg_internal (qemu-system-x86_64 + 0x9c8ccf)
>>> #5 0x0000558c349f6899 object_property_try_add (qemu-system-x86_64 + 0x7f6899)
>>> #6 0x0000558c349f7df8 object_property_try_add_child (qemu-system-x86_64 + 0x7f7df8)
>>> #7 0x0000558c349f7e91 object_property_add_child (qemu-system-x86_64 + 0x7f7e91)
>>> #8 0x0000558c3454686d create_default_memdev (qemu-system-x86_64 + 0x34686d)
>>> #9 0x0000558c34546f58 qemu_init_board (qemu-system-x86_64 + 0x346f58)
>>> #10 0x0000558c345471b9 qmp_x_exit_preconfig (qemu-system-x86_64 + 0x3471b9)
>>> #11 0x0000558c345497d9 qemu_init (qemu-system-x86_64 + 0x3497d9)
>>> #12 0x0000558c344e54c2 main (qemu-system-x86_64 + 0x2e54c2)
>>> #13 0x00007fb109a7e34d __libc_start_main (libc.so.6 + 0x2534d)
>>> #14 0x0000558c344e53ba _start (qemu-system-x86_64 + 0x2e53ba)
>>>
>>> Signed-off-by: Li Zhang <lizhang@suse.de>
>>
>> Acked-by: Igor Mammedov <imammedo@redhat.com>
>>
>>
>> CCing David as he probably would be the one to merge it
>>
>
> Thanks for your review.
Acked-by: David Hildenbrand <david@redhat.com>
Paolo, can you queue this?
https://lore.kernel.org/qemu-devel/20220613104402.10279-1-lizhang@suse.de/
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id
2022-06-13 15:31 ` David Hildenbrand
@ 2022-06-20 12:09 ` Li Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Li Zhang @ 2022-06-20 12:09 UTC (permalink / raw)
To: Paolo Bonzini, David Hildenbrand
Cc: Igor Mammedov, Li Zhang, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, QEMU
On Mon, Jun 13, 2022 at 5:31 PM David Hildenbrand <david@redhat.com> wrote:
>
> On 13.06.22 16:37, Li Zhang wrote:
> > On Mon, Jun 13, 2022 at 4:19 PM Igor Mammedov <imammedo@redhat.com> wrote:
> >>
> >> On Mon, 13 Jun 2022 12:44:02 +0200
> >> Li Zhang <lizhang@suse.de> wrote:
> >>
> >>> When no memory backend is specified in machine options,
> >>> a default memory device will be added with default_ram_id.
> >>> However, if a memory backend object is added in QEMU options
> >>> and id is the same as default_ram_id, a coredump happens.
> >>>
> >>> Command line:
> >>> qemu-system-x86_64 -name guest=vmtest,debug-threads=on \
> >>> -machine pc-q35-6.0,accel=kvm,usb=off,vmport=off \
> >>> -smp 16,sockets=16,cores=1,threads=1 \
> >>> -m 4G \
> >>> -object memory-backend-ram,id=pc.ram,size=4G \
> >>> -no-user-config -nodefaults -nographic
> >>>
> >>> Stack trace of thread 16903:
> >>> #0 0x00007fb109a9318b raise (libc.so.6 + 0x3a18b)
> >>> #1 0x00007fb109a94585 abort (libc.so.6 + 0x3b585)
> >>> #2 0x0000558c34bc89be error_handle_fatal (qemu-system-x86_64 + 0x9c89be)
> >>> #3 0x0000558c34bc8aee error_setv (qemu-system-x86_64 + 0x9c8aee)
> >>> #4 0x0000558c34bc8ccf error_setg_internal (qemu-system-x86_64 + 0x9c8ccf)
> >>> #5 0x0000558c349f6899 object_property_try_add (qemu-system-x86_64 + 0x7f6899)
> >>> #6 0x0000558c349f7df8 object_property_try_add_child (qemu-system-x86_64 + 0x7f7df8)
> >>> #7 0x0000558c349f7e91 object_property_add_child (qemu-system-x86_64 + 0x7f7e91)
> >>> #8 0x0000558c3454686d create_default_memdev (qemu-system-x86_64 + 0x34686d)
> >>> #9 0x0000558c34546f58 qemu_init_board (qemu-system-x86_64 + 0x346f58)
> >>> #10 0x0000558c345471b9 qmp_x_exit_preconfig (qemu-system-x86_64 + 0x3471b9)
> >>> #11 0x0000558c345497d9 qemu_init (qemu-system-x86_64 + 0x3497d9)
> >>> #12 0x0000558c344e54c2 main (qemu-system-x86_64 + 0x2e54c2)
> >>> #13 0x00007fb109a7e34d __libc_start_main (libc.so.6 + 0x2534d)
> >>> #14 0x0000558c344e53ba _start (qemu-system-x86_64 + 0x2e53ba)
> >>>
> >>> Signed-off-by: Li Zhang <lizhang@suse.de>
> >>
> >> Acked-by: Igor Mammedov <imammedo@redhat.com>
> >>
> >>
> >> CCing David as he probably would be the one to merge it
> >>
> >
> > Thanks for your review.
>
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
>
Thanks David.
> Paolo, can you queue this?
>
> https://lore.kernel.org/qemu-devel/20220613104402.10279-1-lizhang@suse.de/
>
Hi Paolo,
It's been acked by Igor and David. Would you please queue this patch?
Thanks
Li
> --
> Thanks,
>
> David / dhildenb
>
--
Best Regards
-Li
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-20 12:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-13 10:44 [PATCH v3 1/1] Fix the coredump when memory backend id conflicts with default_ram_id Li Zhang
2022-06-13 14:19 ` Igor Mammedov
2022-06-13 14:37 ` Li Zhang
2022-06-13 15:31 ` David Hildenbrand
2022-06-20 12:09 ` Li Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).