From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55396)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhlcindy@gmail.com>) id 1T1pcw-0007vO-OG
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 22:16:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhlcindy@gmail.com>) id 1T1pcv-0006M6-GV
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 22:16:02 -0400
MIME-Version: 1.0
In-Reply-To: <1345081931.11751.19.camel@pasglop>
References: <1344966575-25952-1-git-send-email-zhlcindy@linux.vnet.ibm.com>
	<1344966575-25952-2-git-send-email-zhlcindy@linux.vnet.ibm.com>
	<21561D9F-70C7-4DCB-86AD-6C844BA59981@suse.de>
	<502B3AF5.8010201@linux.vnet.ibm.com>
	<30B60976-E886-46D8-9798-23962C00B320@suse.de>
	<502C4D06.5070706@linux.vnet.ibm.com>
	<1345081931.11751.19.camel@pasglop>
Date: Thu, 16 Aug 2012 10:15:59 +0800
Message-ID: <CAD8of+qXX=sQn7MSFfrhFuqbscdx3CSXaErY=spQLS_OebVQTw@mail.gmail.com>
From: Li Zhang <zhlcindy@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v8 2/2] Add USB enablement on
	sPAPR platform.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "aliguori@us.ibm.com" <aliguori@us.ibm.com>, Alexander Graf <agraf@suse.de>, Li Zhang <zhlcindy@linux.vnet.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>

On Thu, Aug 16, 2012 at 9:52 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Thu, 2012-08-16 at 09:29 +0800, Li Zhang wrote:
>> > Yes, that's pretty much what I was asking for (here and for the
>> mac99 u3 machine). Just base your patch on ppc-next. My patches are in
>> there.
>> That's great. Thanks a lot!
>
> Note that you missed the hard freeze for qemu 1.2, it was today.
>
> So we'll have to do a simpler patch to wire up USB to pseries for 1.2
> and delay your work for the next release.
>
> Something along the lines in spapr.c of:
>
>   if (usb_enabled) {
>      instanciate ohci
>      if (vga enabled) {
>         add mouse & kbd
>      }
>   }

Oh, so sorry for that. I will do that for next release.

> Cheers,
> Ben.
>
>
-- 

Best Regards
-Li