From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSRdl-0002JP-QT for qemu-devel@nongnu.org; Tue, 25 Mar 2014 09:43:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSRdk-0002yI-H9 for qemu-devel@nongnu.org; Tue, 25 Mar 2014 09:43:41 -0400 Received: from mail-oa0-x22e.google.com ([2607:f8b0:4003:c02::22e]:56596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSRdk-0002yA-Br for qemu-devel@nongnu.org; Tue, 25 Mar 2014 09:43:40 -0400 Received: by mail-oa0-f46.google.com with SMTP id i7so563116oag.33 for ; Tue, 25 Mar 2014 06:43:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <533176B1.9060103@codeaurora.org> References: <1395718484-20424-1-git-send-email-joelf@ti.com> <533176B1.9060103@codeaurora.org> Date: Tue, 25 Mar 2014 08:43:39 -0500 Message-ID: From: Joel Fernandes Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image friendly address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christopher Covington Cc: Joel Fernandes , qemu-devel@nongnu.org, Linux ARM Kernel List On Tue, Mar 25, 2014 at 7:29 AM, Christopher Covington wrote: > Hi Joel, > > On 03/24/2014 11:34 PM, Joel Fernandes wrote: >> Loading kernel at offset 0x10000 works only for zImage, but not for Image, >> because the kernel expect the start of decompressed kernel (.head.text) to be > > Nit: expects > >> at an address that's a distance that's 16MB aligned from PAGE_OFFSET + >> TEXT_OFFSET (see vmlinux.lds.S). This check is enfornced in __fixup_pv_table in > > Nit: enforced > >> arch/arm/kernel/head.S TEXT_OFFSET is 0x00008000, so a 16MB alignment needs to >> have a "0x8000" in the lower 16 bits so that they cancel out. Currently the >> offset Qemu loads it at is 0x10000. >> >> With zImage, this need is met because zImage loads the uncompressed Image >> correctly, however when loading an Image and executing directly Qemu is >> required it to load it at the correct location. Doing so, doesn't break Qemu's >> zImage loading. With this patch, both zImage and Image work correctly. > > I had just been playing with my own version of this change. Glad to see it > going upstream. > > Tested-by: Christopher Covington > Thanks, I updated the patch with these changes. -Joel