From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9677DC433E0 for ; Mon, 6 Jul 2020 23:30:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FF61206E9 for ; Mon, 6 Jul 2020 23:30:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mgg1+R1w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FF61206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsaZR-0003tN-LP for qemu-devel@archiver.kernel.org; Mon, 06 Jul 2020 19:30:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsaYd-0002lY-EV; Mon, 06 Jul 2020 19:29:55 -0400 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]:33034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsaYb-0006VX-On; Mon, 06 Jul 2020 19:29:55 -0400 Received: by mail-io1-xd42.google.com with SMTP id i25so41344312iog.0; Mon, 06 Jul 2020 16:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=guo4Cz0saHkzfASqoW+5Vfcn07JMdPw0vLJcHYngdVg=; b=Mgg1+R1wgP3yxWPoxwWzVSxY2DBC9uea+PFILvRzMeodl7CDSW6RFuIaULNGjbl5Wm e+hCc1T3Xll8LfByGqK3TY3w+7eAb71d7Ae0R0447AX36sCNNoaUbvfaW3MjOyeRnMve s+nQuLbys2Cq6ZKBNVYoyxUZYEAcwfG4E1nUQkp22Dcn+sEZ6SgV+248afpNz2u0S6YB DeqGJkSGAO5axe7LmsN1L9ov27T4ZifdZ/+d5Qwvyv7PifaQb7LkaWs8K+/MJCfwnF2U OM/aWXU/Cp7UwxJaN304YU1X6zGqzj9Ed2BvtxVv3622J/wOVdGJLZ5TIYdbStGq2jRR 0dnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=guo4Cz0saHkzfASqoW+5Vfcn07JMdPw0vLJcHYngdVg=; b=ck5Gx3mnSh8ejGXXKb/ryETte7/RI85yONMnlHTb/wRWWvs2EV1Jh5mneCGSojAN+2 EgYFpFaUUW1zb7NW4Lv+SbHw7GfFsInDYMmMnldjbru8Zfyh7KGZOOQWUYtGaZSGNK5/ YGMP5tNdfssixcy/F0JNhFqZEtQemZiSTmpS5JSkWHoBpcy7NHdQFyUvIPzL+ntsLPV+ cFGZGDIMuUXtHt8fxYgT3M2HVkkIe6q6dBt8FfOCfhhmZqwfIDzYlFa51x629PrBnSvY qcKgRoCDYIl1vs8WBgcgfmcWFU06wRzwjNEsGdV+u61JmEZ5cLwCqme88iyKN82/hKrU ZPLg== X-Gm-Message-State: AOAM532025LKFz2h97Nc1aIj8R7sgdEnnUyPT7rYNtKkiIG12Ofu+kyv HaKzrw0hjJPWbgdt2ZDW3pbL6hJrgS4+Ta53vLk= X-Google-Smtp-Source: ABdhPJxccJUFvrRtMWh3+owZpgS6w9Fdz4b7CnGGaHawyuF5NA7yGHARPV7RXQDl8sKlO2zqMYBeBAVye8DBVl2kztM= X-Received: by 2002:a5e:dc03:: with SMTP id b3mr26345208iok.97.1594078191753; Mon, 06 Jul 2020 16:29:51 -0700 (PDT) MIME-Version: 1.0 References: <20200704144943.18292-1-f4bug@amsat.org> <20200704144943.18292-9-f4bug@amsat.org> In-Reply-To: <20200704144943.18292-9-f4bug@amsat.org> From: Paul Zimmerman Date: Mon, 6 Jul 2020 16:29:25 -0700 Message-ID: Subject: Re: [PATCH 08/26] hw/usb/hcd-dwc2: Restrict 'dwc2-regs.h' scope To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="0000000000005d234a05a9ce40b4" Received-SPF: pass client-ip=2607:f8b0:4864:20::d42; envelope-from=pauldzim@gmail.com; helo=mail-io1-xd42.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Mark Cave-Ayland , QEMU Developers , Gerd Hoffmann , "Edgar E. Iglesias" , Huacai Chen , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , Paul Durrant , Magnus Damm , Markus Armbruster , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Anthony Perard , Samuel Thibault , Leif Lindholm , Aleksandar Rikalo , Eduardo Habkost , Alistair Francis , "Dr. David Alan Gilbert" , Beniamino Galvani , Niek Linnenbank , qemu-arm@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Richard Henderson , Radoslaw Biernacki , Igor Mitsyanko , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-ppc@nongnu.org, David Gibson , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000005d234a05a9ce40b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daud=C3=A9 wrote: > We only use these register definitions in files under the > hw/usb/ directory. Keep that header local by moving it there. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > {include/hw =3D> hw}/usb/dwc2-regs.h | 0 > hw/usb/hcd-dwc2.c | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename {include/hw =3D> hw}/usb/dwc2-regs.h (100%) > > diff --git a/include/hw/usb/dwc2-regs.h b/hw/usb/dwc2-regs.h > similarity index 100% > rename from include/hw/usb/dwc2-regs.h > rename to hw/usb/dwc2-regs.h > diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c > index ccf05d0823..252b60ef65 100644 > --- a/hw/usb/hcd-dwc2.c > +++ b/hw/usb/hcd-dwc2.c > @@ -34,7 +34,6 @@ > #include "qemu/osdep.h" > #include "qemu/units.h" > #include "qapi/error.h" > -#include "hw/usb/dwc2-regs.h" > #include "hw/usb/hcd-dwc2.h" > #include "hw/irq.h" > #include "sysemu/dma.h" > @@ -43,6 +42,7 @@ > #include "qemu/timer.h" > #include "qemu/log.h" > #include "hw/qdev-properties.h" > +#include "dwc2-regs.h" > > #define USB_HZ_FS 12000000 > #define USB_HZ_HS 96000000 > -- > 2.21.3 > > Reviewed-by: Paul Zimmerman --0000000000005d234a05a9ce40b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathi= eu-Daud=C3=A9 <f4bug@amsat.org>= ; wrote:
We only= use these register definitions in files under the
hw/usb/ directory. Keep that header local by moving it there.

Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
---
=C2=A0{include/hw =3D> hw}/usb/dwc2-regs.h | 0
=C2=A0hw/usb/hcd-dwc2.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | 2 +-
=C2=A02 files changed, 1 insertion(+), 1 deletion(-)
=C2=A0rename {include/hw =3D> hw}/usb/dwc2-regs.h (100%)

diff --git a/include/hw/usb/dwc2-regs.h b/hw/usb/dwc2-regs.h
similarity index 100%
rename from include/hw/usb/dwc2-regs.h
rename to hw/usb/dwc2-regs.h
diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c
index ccf05d0823..252b60ef65 100644
--- a/hw/usb/hcd-dwc2.c
+++ b/hw/usb/hcd-dwc2.c
@@ -34,7 +34,6 @@
=C2=A0#include "qemu/osdep.h"
=C2=A0#include "qemu/units.h"
=C2=A0#include "qapi/error.h"
-#include "hw/usb/dwc2-regs.h"
=C2=A0#include "hw/usb/hcd-dwc2.h"
=C2=A0#include "hw/irq.h"
=C2=A0#include "sysemu/dma.h"
@@ -43,6 +42,7 @@
=C2=A0#include "qemu/timer.h"
=C2=A0#include "qemu/log.h"
=C2=A0#include "hw/qdev-properties.h"
+#include "dwc2-regs.h"

=C2=A0#define USB_HZ_FS=C2=A0 =C2=A0 =C2=A0 =C2=A012000000
=C2=A0#define USB_HZ_HS=C2=A0 =C2=A0 =C2=A0 =C2=A096000000
--
2.21.3


Re= viewed-by:=C2= =A0Paul Zimmerman <pauldzim@gmail.= com>
--0000000000005d234a05a9ce40b4--