From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxeQ5-0003p8-22 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:38:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxePz-0008Lg-OE for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:38:32 -0400 Received: from mail-qc0-f170.google.com ([209.85.216.170]:61515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxePz-0008Kv-Jq for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:38:27 -0400 Received: by mail-qc0-f170.google.com with SMTP id l6so2349108qcy.15 for ; Thu, 19 Jun 2014 08:38:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140619153543.GB10724@redhat.com> References: <20140619150355.10499.53297.stgit@3820> <20140619150708.10499.23280.stgit@3820> <20140619153543.GB10724@redhat.com> From: Nikolay Nikolaev Date: Thu, 19 Jun 2014 18:38:06 +0300 Message-ID: Content-Type: multipart/alternative; boundary=001a1139766002cef804fc322b85 Subject: Re: [Qemu-devel] [snabb-devel] Re: [PATCH 1/6] configure: add new config define CONFIG_VHOST_NET_USED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "snabb-devel@googlegroups.com" Cc: VirtualOpenSystems Technical Team , qemu-devel --001a1139766002cef804fc322b85 Content-Type: text/plain; charset=UTF-8 On Thu, Jun 19, 2014 at 6:35 PM, Michael S. Tsirkin wrote: > On Thu, Jun 19, 2014 at 06:07:15PM +0300, Nikolay Nikolaev wrote: > > This will be used in net.c (for now) to enable vhos-user netdev backend. > > > > Signed-off-by: Nikolay Nikolaev > > Did you test this with mingw? > No, I didn't manage to setup mingw under linux. But this "vhost_net" should be enabled only for linux in configure. So if I understand it properly, mingw should be safe. regards, Nikolay Nikolaev > > > --- > > configure | 3 +++ > > net/net.c | 4 ++-- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/configure b/configure > > index 9f4ba45..fb3c856 100755 > > --- a/configure > > +++ b/configure > > @@ -4543,6 +4543,9 @@ fi > > if test "$vhost_scsi" = "yes" ; then > > echo "CONFIG_VHOST_SCSI=y" >> $config_host_mak > > fi > > +if test "$vhost_net" = "yes" ; then > > + echo "CONFIG_VHOST_NET_USED=y" >> $config_host_mak > > +fi > > if test "$blobs" = "yes" ; then > > echo "INSTALL_BLOBS=yes" >> $config_host_mak > > fi > > diff --git a/net/net.c b/net/net.c > > index 0c30414..3dac29b 100644 > > --- a/net/net.c > > +++ b/net/net.c > > @@ -803,7 +803,7 @@ static int (* const > net_client_init_fun[NET_CLIENT_OPTIONS_KIND_MAX])( > > [NET_CLIENT_OPTIONS_KIND_BRIDGE] = net_init_bridge, > > #endif > > [NET_CLIENT_OPTIONS_KIND_HUBPORT] = net_init_hubport, > > -#ifdef CONFIG_VHOST_NET > > +#ifdef CONFIG_VHOST_NET_USED > > [NET_CLIENT_OPTIONS_KIND_VHOST_USER] = net_init_vhost_user, > > #endif > > }; > > @@ -839,7 +839,7 @@ static int net_client_init1(const void *object, int > is_netdev, Error **errp) > > case NET_CLIENT_OPTIONS_KIND_BRIDGE: > > #endif > > case NET_CLIENT_OPTIONS_KIND_HUBPORT: > > -#ifdef CONFIG_VHOST_NET > > +#ifdef CONFIG_VHOST_NET_USED > > case NET_CLIENT_OPTIONS_KIND_VHOST_USER: > > #endif > > break; > > -- > You received this message because you are subscribed to the Google Groups > "Snabb Switch development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to snabb-devel+unsubscribe@googlegroups.com. > To post to this group, send an email to snabb-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/snabb-devel. > --001a1139766002cef804fc322b85 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



On Thu, Jun 19, 2014 at 6:35 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
On Thu, Jun 19, 2014 at 06:0= 7:15PM +0300, Nikolay Nikolaev wrote:
> This will be used in net.c (for now) to enable vhos-user netdev backen= d.
>
> Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>

Did you test this with mingw?

No,= I didn't manage to setup mingw under linux. But this "vhost_net&q= uot; should be enabled only for linux in configure. So if I understand it p= roperly, mingw should be safe.

regards,
Nikolay Nikolaev
=C2=A0

> ---
> =C2=A0configure | =C2=A0 =C2=A03 +++
> =C2=A0net/net.c | =C2=A0 =C2=A04 ++--
> =C2=A02 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 9f4ba45..fb3c856 100755
> --- a/configure
> +++ b/configure
> @@ -4543,6 +4543,9 @@ fi
> =C2=A0if test "$vhost_scsi" =3D "yes" ; then
> =C2=A0 =C2=A0echo "CONFIG_VHOST_SCSI=3Dy" >> $config_h= ost_mak
> =C2=A0fi
> +if test "$vhost_net" =3D "yes" ; then
> + =C2=A0echo "CONFIG_VHOST_NET_USED=3Dy" >> $config_ho= st_mak
> +fi
> =C2=A0if test "$blobs" =3D "yes" ; then
> =C2=A0 =C2=A0echo "INSTALL_BLOBS=3Dyes" >> $config_hos= t_mak
> =C2=A0fi
> diff --git a/net/net.c b/net/net.c
> index 0c30414..3dac29b 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -803,7 +803,7 @@ static int (* const net_client_init_fun[NET_CLIENT= _OPTIONS_KIND_MAX])(
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[NET_CLIENT_OPTIONS_KIND_BRIDGE] =C2= =A0 =C2=A0=3D net_init_bridge,
> =C2=A0#endif
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[NET_CLIENT_OPTIONS_KIND_HUBPORT] = =C2=A0 =3D net_init_hubport,
> -#ifdef CONFIG_VHOST_NET
> +#ifdef CONFIG_VHOST_NET_USED
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[NET_CLIENT_OPTIONS_KIND_VHOST_USER]= =3D net_init_vhost_user,
> =C2=A0#endif
> =C2=A0};
> @@ -839,7 +839,7 @@ static int net_client_init1(const void *object, in= t is_netdev, Error **errp)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case NET_CLIENT_OPTIONS_KIND_BRIDGE:=
> =C2=A0#endif
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case NET_CLIENT_OPTIONS_KIND_HUBPORT= :
> -#ifdef CONFIG_VHOST_NET
> +#ifdef CONFIG_VHOST_NET_USED
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case NET_CLIENT_OPTIONS_KIND_VHOST_U= SER:
> =C2=A0#endif
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;

--
You received this message because you are subscribed to the Google Groups &= quot;Snabb Switch development" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to snabb= -devel+unsubscribe@googlegroups.com.
To post to this group, send an email to snabb-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/snabb-devel.

--001a1139766002cef804fc322b85--