From: Doug Evans <dje@google.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support
Date: Fri, 19 Feb 2021 13:43:33 -0800 [thread overview]
Message-ID: <CADPb22TmdB641e_OecWRqqmFEDmEx8+GM-cL+aWMLcVgVpykZQ@mail.gmail.com> (raw)
In-Reply-To: <YC+HDHCm0vtoXXs1@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
On Fri, Feb 19, 2021 at 1:38 AM Daniel P. Berrangé <berrange@redhat.com>
wrote:
> On Thu, Feb 18, 2021 at 12:15:35PM -0800, Doug Evans wrote:
>
> FWIW, normally when QEMU updates libslirp, the commit message is
> set to contain the "git shortlog old..new" output
>
Ah. In this case I'm not sure what to do as QEMU master is using Libslirp
stable-4.2 branch (at least in QEMU's libslirp.git).
Samuel, please let me know what should happen here.
I may need some hand holding to come up with The Right patch to submit.
I think you know what patches are needed here, but I don't know what I
should be submitting in this 1/4 patch of the series.
>
> > Signed-off-by: Doug Evans <dje@google.com>
> > ---
> >
> > Changes from v3:
> > - pick up latest libslirp patch to reject ipv6 addr-any for guest address
> > - libslirp currently only provides a stateless DHCPv6 server, which
> means
> > it can't know in advance what the guest's IP address is, and thus
> > cannot do the "addr-any -> guest ip address" translation that is done
> > for ipv4
> >
> > Changes from v2:
> > - this patch is new in v3, split out from v2
> >
> > slirp | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/slirp b/slirp
> > index 8f43a99191..26ae658a83 160000
> > --- a/slirp
> > +++ b/slirp
> > @@ -1 +1 @@
> > -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
> > +Subproject commit 26ae658a83eeca16780cf5615c8247cbb151c3fa
> > --
> > 2.30.0.617.g56c4b15f3c-goog
> >
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o-
> https://www.instagram.com/dberrange :|
>
>
[-- Attachment #2: Type: text/html, Size: 3409 bytes --]
next prev parent reply other threads:[~2021-02-19 21:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 20:15 [PATCH v4 0/4] Add support for ipv6 host forwarding Doug Evans via
2021-02-18 20:15 ` [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support Doug Evans via
2021-02-19 9:38 ` Daniel P. Berrangé
2021-02-19 21:43 ` Doug Evans [this message]
2021-02-18 20:15 ` [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse Doug Evans via
2021-02-19 10:00 ` Daniel P. Berrangé
2021-02-19 22:17 ` Doug Evans
2021-02-22 9:39 ` Daniel P. Berrangé
2021-02-23 18:23 ` Doug Evans
2021-02-28 21:39 ` Samuel Thibault
2021-02-28 22:20 ` Samuel Thibault
2021-03-01 8:15 ` Markus Armbruster
2021-03-01 8:31 ` Samuel Thibault
2021-03-01 16:07 ` Doug Evans
2021-03-01 16:26 ` Samuel Thibault
2021-03-01 20:39 ` Samuel Thibault
2021-03-01 16:23 ` Doug Evans
2021-03-01 16:27 ` Samuel Thibault
2021-03-01 21:05 ` Samuel Thibault
2021-03-03 18:06 ` Doug Evans
2021-03-03 18:11 ` Daniel P. Berrangé
2021-03-05 21:28 ` Samuel Thibault
2021-03-05 21:51 ` Doug Evans
2021-03-05 22:21 ` Doug Evans
2021-03-06 0:05 ` Doug Evans
2021-03-06 0:10 ` Samuel Thibault
2021-03-06 1:00 ` Doug Evans
2021-03-06 19:29 ` Samuel Thibault
2021-03-14 19:52 ` Doug Evans
2021-02-18 20:15 ` [PATCH v4 3/4] net/slirp.c: Refactor address parsing Doug Evans via
2021-02-18 20:15 ` [PATCH v4 4/4] net: Extend host forwarding to support IPv6 Doug Evans via
2021-02-18 20:34 ` [PATCH v4 0/4] Add support for ipv6 host forwarding no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TmdB641e_OecWRqqmFEDmEx8+GM-cL+aWMLcVgVpykZQ@mail.gmail.com \
--to=dje@google.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).