From: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>
Subject: Re: [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read
Date: Mon, 23 Oct 2023 11:38:32 +0200 [thread overview]
Message-ID: <CADS1RdShzeE_VCMDMjCEcN06f6cEVh3dQ61g=oOKSsEBJAwuuA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKPJoyMmoNAX9JrHz6_SSphqRkEJPy3AUaV0eu+701Ow9g@mail.gmail.com>
On Mon, 23 Oct 2023 at 03:37, Alistair Francis <alistair23@gmail.com> wrote:
>
> On Sat, Oct 21, 2023 at 4:12 AM Philippe Mathieu-Daudé
> <philmd@linaro.org> wrote:
> >
> > From: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
> >
> > Signed-off-by: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
> > [PMD: Split from bigger patch]
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > Is this required?
>
> I don't think this is required
>
> Alistair
I agree this should be removed. It was added because the manual says
that some irq:s are cleared by a combination of reading SR and writing
to DR. However, those bits are not implemented yet, and probably the
clearing should be done when writing DR anyway.
Thanks for reviewing,
Hans-Erik
next prev parent reply other threads:[~2023-10-23 9:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:00 [PATCH v2 0/4] stm32f2xx_usart: implement TX interrupts Philippe Mathieu-Daudé
2023-10-20 17:00 ` [PATCH v2 1/4] hw/char/stm32f2xx_usart: Extract common IRQ update code to update_irq() Philippe Mathieu-Daudé
2023-10-22 16:53 ` Richard Henderson
2023-10-23 1:34 ` Alistair Francis
2023-10-20 17:00 ` [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read Philippe Mathieu-Daudé
2023-10-22 16:54 ` Richard Henderson
2023-10-23 1:36 ` Alistair Francis
2023-10-23 9:38 ` Hans-Erik Floryd [this message]
2023-10-20 17:00 ` [PATCH v2 3/4] hw/char/stm32f2xx_usart: Update IRQ when DR is written Philippe Mathieu-Daudé
2023-10-22 16:54 ` Richard Henderson
2023-10-23 1:37 ` Alistair Francis
2023-10-20 17:00 ` [PATCH v2 4/4] hw/char/stm32f2xx_usart: Add more definitions for CR1 register Philippe Mathieu-Daudé
2023-10-22 16:54 ` Richard Henderson
2023-10-23 1:38 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADS1RdShzeE_VCMDMjCEcN06f6cEVh3dQ61g=oOKSsEBJAwuuA@mail.gmail.com' \
--to=hans-erik.floryd@rt-labs.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).