Re: [RFC 1/2] linux-headers: add virtio_can.h

[Albert Esteve <aesteve@redhat.com>]

On Fri, Oct 31, 2025 at 5:00 PM Matias Ezequiel Vara Larsen
<mvaralar@redhat.com> wrote:
>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> Note that virtio_can.h is not merged yet and it is part of the series
> https://lore.kernel.org/all/aQJRnX7OpFRY%2F1+H@fedora/

Hi Matias,

As far as I know, standard-headers must be updated with
`./scripts/update-linux-headers.sh`, so unless exceptions can be it'll
have to wait until the kernel patch is merged for this to be accepted.


> ---
>  include/standard-headers/linux/virtio_can.h | 78 +++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 include/standard-headers/linux/virtio_can.h
>
> diff --git a/include/standard-headers/linux/virtio_can.h b/include/standard-headers/linux/virtio_can.h
> new file mode 100644
> index 0000000000..6380ef7bce
> --- /dev/null
> +++ b/include/standard-headers/linux/virtio_can.h
> @@ -0,0 +1,78 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/*
> + * Copyright (C) 2021-2023 OpenSynergy GmbH
> + * Copyright Red Hat, Inc. 2025
> + */
> +#ifndef _LINUX_VIRTIO_VIRTIO_CAN_H
> +#define _LINUX_VIRTIO_VIRTIO_CAN_H
> +
> +#include <standard-headers/linux/types.h>
> +#include <standard-headers/linux/virtio_types.h>
> +#include <standard-headers/linux/virtio_ids.h>
> +#include <standard-headers/linux/virtio_config.h>
> +
> +/* Feature bit numbers */
> +#define VIRTIO_CAN_F_CAN_CLASSIC        0
> +#define VIRTIO_CAN_F_CAN_FD             1
> +#define VIRTIO_CAN_F_RTR_FRAMES         2
> +#define VIRTIO_CAN_F_LATE_TX_ACK        3
> +
> +/* CAN Result Types */
> +#define VIRTIO_CAN_RESULT_OK            0
> +#define VIRTIO_CAN_RESULT_NOT_OK        1
> +
> +/* CAN flags to determine type of CAN Id */
> +#define VIRTIO_CAN_FLAGS_EXTENDED       0x8000
> +#define VIRTIO_CAN_FLAGS_FD             0x4000
> +#define VIRTIO_CAN_FLAGS_RTR            0x2000
> +
> +#define VIRTIO_CAN_MAX_DLEN    64 // this is like CANFD_MAX_DLEN
> +
> +struct virtio_can_config {
> +#define VIRTIO_CAN_S_CTRL_BUSOFF (1u << 0) /* Controller BusOff */
> +       /* CAN controller status */
> +       __le16 status;
> +};
> +
> +/* TX queue message types */
> +struct virtio_can_tx_out {
> +#define VIRTIO_CAN_TX                   0x0001
> +       __le16 msg_type;
> +       __le16 length; /* 0..8 CC, 0..64 CAN-FD, 0..2048 CAN-XL, 12 bits */
> +       __u8 reserved_classic_dlc; /* If CAN classic length = 8 then DLC can be 8..15 */
> +       __u8 padding;
> +       __le16 reserved_xl_priority; /* May be needed for CAN XL priority */
> +       __le32 flags;
> +       __le32 can_id;
> +       __u8 sdu[] __counted_by(length);
> +};
> +
> +struct virtio_can_tx_in {
> +       __u8 result;
> +};
> +
> +/* RX queue message types */
> +struct virtio_can_rx {
> +#define VIRTIO_CAN_RX                   0x0101
> +       __le16 msg_type;
> +       __le16 length; /* 0..8 CC, 0..64 CAN-FD, 0..2048 CAN-XL, 12 bits */
> +       __u8 reserved_classic_dlc; /* If CAN classic length = 8 then DLC can be 8..15 */
> +       __u8 padding;
> +       __le16 reserved_xl_priority; /* May be needed for CAN XL priority */
> +       __le32 flags;
> +       __le32 can_id;
> +       __u8 sdu[] __counted_by(length);
> +};
> +
> +/* Control queue message types */
> +struct virtio_can_control_out {
> +#define VIRTIO_CAN_SET_CTRL_MODE_START  0x0201
> +#define VIRTIO_CAN_SET_CTRL_MODE_STOP   0x0202
> +       __le16 msg_type;
> +};
> +
> +struct virtio_can_control_in {
> +       __u8 result;
> +};
> +
> +#endif /* #ifndef _LINUX_VIRTIO_VIRTIO_CAN_H */
> --
> 2.42.0
>
>