From: Beata Michalska <beata.michalska@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
kvmarm@lists.cs.columbia.edu,
QEMU Developers <qemu-devel@nongnu.org>,
Christoffer Dall <Christoffer.Dall@arm.com>
Subject: Re: [PATCH v6 1/2] target/arm: kvm: Handle DABT with no valid ISS
Date: Sat, 27 Jun 2020 16:29:31 +0100 [thread overview]
Message-ID: <CADSWDzvW3v0bVaEjaPLSk_N4c8nA_ZcReerh2dd3Lg2jgDRiHQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_pKMkwAGAAdkCXk3dOqJQnX+qRsZuLMWA0qfMsw+aF1Q@mail.gmail.com>
Hi Peter,
Hi Andrew
Thanks for quick review.
I have pushed the updated version.
BR
Beata
On Fri, 26 Jun 2020 at 13:59, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 26 Jun 2020 at 10:01, Andrew Jones <drjones@redhat.com> wrote:
> > nit: How about using '= {0}' when declaring the variable, rather than this
> > memset?
>
> We prefer "= {}" -- although "= {0}" is the C standard approved
> version, some compiler versions produce spurious warnings for
> it in some situations. (cf commit 039d4e3df0049bdd8f9).
>
> thanks
> -- PMM
next prev parent reply other threads:[~2020-06-27 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 22:03 [PATCH v6 0/2] target/arm: kvm: Support for KVM DABT with no valid ISS Beata Michalska
2020-06-25 22:03 ` [PATCH v6 1/2] target/arm: kvm: Handle " Beata Michalska
2020-06-26 9:00 ` Andrew Jones
2020-06-26 12:59 ` Peter Maydell
2020-06-27 15:29 ` Beata Michalska [this message]
2020-06-25 22:03 ` [PATCH v6 2/2] target/arm: kvm: Handle misconfigured dabt injection Beata Michalska
2020-06-26 9:12 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADSWDzvW3v0bVaEjaPLSk_N4c8nA_ZcReerh2dd3Lg2jgDRiHQ@mail.gmail.com \
--to=beata.michalska@linaro.org \
--cc=Christoffer.Dall@arm.com \
--cc=drjones@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).