* [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64
@ 2024-05-28 10:23 Will Gyda
2024-05-29 7:07 ` Paolo Bonzini
2024-05-29 10:12 ` Manos Pitsidianakis
0 siblings, 2 replies; 6+ messages in thread
From: Will Gyda @ 2024-05-28 10:23 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, philmd, pbonzini, richard.henderson, eduardo,
Will Gyda
Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
Solution: microvm is now not build if only Xen is available.
Signed-off-by: Will Gyda <vilhelmgyda@gmail.com>
---
configs/devices/i386-softmmu/default.mak | 2 +-
hw/i386/Kconfig | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
index 598c6646df..6a73aee7dd 100644
--- a/configs/devices/i386-softmmu/default.mak
+++ b/configs/devices/i386-softmmu/default.mak
@@ -29,4 +29,4 @@
CONFIG_ISAPC=y
CONFIG_I440FX=y
CONFIG_Q35=y
-CONFIG_MICROVM=y
+#CONFIG_MICROVM=n
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index a6ee052f9a..f8ec8ebd7a 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -108,6 +108,8 @@ config Q35
config MICROVM
bool
+ default y
+ depends on KVM || WHPX || NVMM || HVF
select SERIAL_ISA # for serial_hds_isa_init()
select ISA_BUS
select APIC
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64
2024-05-28 10:23 [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64 Will Gyda
@ 2024-05-29 7:07 ` Paolo Bonzini
2024-05-29 8:24 ` Vilhelm Gyda
2024-05-29 10:12 ` Manos Pitsidianakis
1 sibling, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2024-05-29 7:07 UTC (permalink / raw)
To: Will Gyda, qemu-devel; +Cc: qemu-trivial, philmd, richard.henderson, eduardo
On 5/28/24 12:23, Will Gyda wrote:
> Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
> Solution: microvm is now not build if only Xen is available.
This does not fix the issue that microvm does not start with a Xen
accelerator. I think it would be better to try and make it work instead.
Paolo
> Signed-off-by: Will Gyda <vilhelmgyda@gmail.com>
>
> ---
> configs/devices/i386-softmmu/default.mak | 2 +-
> hw/i386/Kconfig | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
> index 598c6646df..6a73aee7dd 100644
> --- a/configs/devices/i386-softmmu/default.mak
> +++ b/configs/devices/i386-softmmu/default.mak
> @@ -29,4 +29,4 @@
> CONFIG_ISAPC=y
> CONFIG_I440FX=y
> CONFIG_Q35=y
> -CONFIG_MICROVM=y
> +#CONFIG_MICROVM=n
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index a6ee052f9a..f8ec8ebd7a 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -108,6 +108,8 @@ config Q35
>
> config MICROVM
> bool
> + default y
> + depends on KVM || WHPX || NVMM || HVF
> select SERIAL_ISA # for serial_hds_isa_init()
> select ISA_BUS
> select APIC
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64
2024-05-29 7:07 ` Paolo Bonzini
@ 2024-05-29 8:24 ` Vilhelm Gyda
2024-05-29 10:09 ` Manos Pitsidianakis
0 siblings, 1 reply; 6+ messages in thread
From: Vilhelm Gyda @ 2024-05-29 8:24 UTC (permalink / raw)
To: Paolo Bonzini
Cc: qemu-devel, qemu-trivial, philmd, richard.henderson, eduardo
@philmd commented on gitlab: Discussed with @epilys on IRC, only Xen
machines (xenpv/xenfv) configure Xen so can run under it.
But if we want to make it work under Xen. Any ideas how to move in
that direction?
On Wed, May 29, 2024 at 12:37 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 5/28/24 12:23, Will Gyda wrote:
> > Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
> > Solution: microvm is now not build if only Xen is available.
>
> This does not fix the issue that microvm does not start with a Xen
> accelerator. I think it would be better to try and make it work instead.
>
> Paolo
>
> > Signed-off-by: Will Gyda <vilhelmgyda@gmail.com>
> >
> > ---
> > configs/devices/i386-softmmu/default.mak | 2 +-
> > hw/i386/Kconfig | 2 ++
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
> > index 598c6646df..6a73aee7dd 100644
> > --- a/configs/devices/i386-softmmu/default.mak
> > +++ b/configs/devices/i386-softmmu/default.mak
> > @@ -29,4 +29,4 @@
> > CONFIG_ISAPC=y
> > CONFIG_I440FX=y
> > CONFIG_Q35=y
> > -CONFIG_MICROVM=y
> > +#CONFIG_MICROVM=n
> > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> > index a6ee052f9a..f8ec8ebd7a 100644
> > --- a/hw/i386/Kconfig
> > +++ b/hw/i386/Kconfig
> > @@ -108,6 +108,8 @@ config Q35
> >
> > config MICROVM
> > bool
> > + default y
> > + depends on KVM || WHPX || NVMM || HVF
> > select SERIAL_ISA # for serial_hds_isa_init()
> > select ISA_BUS
> > select APIC
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64
2024-05-29 8:24 ` Vilhelm Gyda
@ 2024-05-29 10:09 ` Manos Pitsidianakis
0 siblings, 0 replies; 6+ messages in thread
From: Manos Pitsidianakis @ 2024-05-29 10:09 UTC (permalink / raw)
To: Vilhelm Gyda
Cc: Paolo Bonzini, qemu-devel, qemu-trivial, philmd,
richard.henderson, eduardo
On Wed, 29 May 2024 at 11:25, Vilhelm Gyda <vilhelmgyda@gmail.com> wrote:
>
> @philmd commented on gitlab: Discussed with @epilys on IRC, only Xen
> machines (xenpv/xenfv) configure Xen so can run under it.
>
> But if we want to make it work under Xen. Any ideas how to move in
> that direction?
We'd have to specify what "works under Xen" means; xen as a type 1
hypervisor? I am trying to think if it makes sense, Xen machines in
qemu already provide PV devices analogously to what microvm promises
to support. What would be the use case for a "hypervisor agnostic"
microvm machine?
>
> On Wed, May 29, 2024 at 12:37 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > On 5/28/24 12:23, Will Gyda wrote:
> > > Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
> > > Solution: microvm is now not build if only Xen is available.
> >
> > This does not fix the issue that microvm does not start with a Xen
> > accelerator. I think it would be better to try and make it work instead.
> >
> > Paolo
> >
> > > Signed-off-by: Will Gyda <vilhelmgyda@gmail.com>
> > >
> > > ---
> > > configs/devices/i386-softmmu/default.mak | 2 +-
> > > hw/i386/Kconfig | 2 ++
> > > 2 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
> > > index 598c6646df..6a73aee7dd 100644
> > > --- a/configs/devices/i386-softmmu/default.mak
> > > +++ b/configs/devices/i386-softmmu/default.mak
> > > @@ -29,4 +29,4 @@
> > > CONFIG_ISAPC=y
> > > CONFIG_I440FX=y
> > > CONFIG_Q35=y
> > > -CONFIG_MICROVM=y
> > > +#CONFIG_MICROVM=n
> > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> > > index a6ee052f9a..f8ec8ebd7a 100644
> > > --- a/hw/i386/Kconfig
> > > +++ b/hw/i386/Kconfig
> > > @@ -108,6 +108,8 @@ config Q35
> > >
> > > config MICROVM
> > > bool
> > > + default y
> > > + depends on KVM || WHPX || NVMM || HVF
> > > select SERIAL_ISA # for serial_hds_isa_init()
> > > select ISA_BUS
> > > select APIC
> >
>
--
Manos Pitsidianakis
Emulation and Virtualization Engineer at Linaro Ltd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64
2024-05-28 10:23 [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64 Will Gyda
2024-05-29 7:07 ` Paolo Bonzini
@ 2024-05-29 10:12 ` Manos Pitsidianakis
2024-05-29 10:56 ` Vilhelm Gyda
1 sibling, 1 reply; 6+ messages in thread
From: Manos Pitsidianakis @ 2024-05-29 10:12 UTC (permalink / raw)
To: qemu-devel, Will Gyda
Cc: qemu-trivial, philmd, pbonzini, richard.henderson, eduardo,
Will Gyda
On Tue, 28 May 2024 13:23, Will Gyda <vilhelmgyda@gmail.com> wrote:
>Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
>Solution: microvm is now not build if only Xen is available.
>
>Signed-off-by: Will Gyda <vilhelmgyda@gmail.com>
>
I suggest rewording the commit title to something like
"i386: remove microvm from default build"
And adding a commit message that explains that the microvm does not work
on Xen, hence if only Xen is available it should not be built.
Also, you can add a
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2294
line before your Signed-off-by. See
https://www.qemu.org/docs/master/devel/submitting-a-patch.html
But, seeing the issue itself, it's about the microvm being stuck under
Xen. So the commit that resolves this would either make it non-stuck or
make it impossible to start the vm to begin with.
>---
> configs/devices/i386-softmmu/default.mak | 2 +-
> hw/i386/Kconfig | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
>index 598c6646df..6a73aee7dd 100644
>--- a/configs/devices/i386-softmmu/default.mak
>+++ b/configs/devices/i386-softmmu/default.mak
>@@ -29,4 +29,4 @@
> CONFIG_ISAPC=y
> CONFIG_I440FX=y
> CONFIG_Q35=y
>-CONFIG_MICROVM=y
>+#CONFIG_MICROVM=n
Better remove this altogether since it's not a default anymore.
>diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
>index a6ee052f9a..f8ec8ebd7a 100644
>--- a/hw/i386/Kconfig
>+++ b/hw/i386/Kconfig
>@@ -108,6 +108,8 @@ config Q35
>
> config MICROVM
> bool
>+ default y
>+ depends on KVM || WHPX || NVMM || HVF
What about TCG? Will it be available if we only build with tcg?
> select SERIAL_ISA # for serial_hds_isa_init()
> select ISA_BUS
> select APIC
>--
>2.25.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64
2024-05-29 10:12 ` Manos Pitsidianakis
@ 2024-05-29 10:56 ` Vilhelm Gyda
0 siblings, 0 replies; 6+ messages in thread
From: Vilhelm Gyda @ 2024-05-29 10:56 UTC (permalink / raw)
To: Manos Pitsidianakis
Cc: qemu-devel, qemu-trivial, philmd, pbonzini, richard.henderson,
eduardo
On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis
<manos.pitsidianakis@linaro.org> wrote:
> What about TCG? Will it be available if we only build with tcg?
I will try doing this, and report back, and will make the suggested
changes, and re-submit.
On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis
<manos.pitsidianakis@linaro.org> wrote:
>
> On Tue, 28 May 2024 13:23, Will Gyda <vilhelmgyda@gmail.com> wrote:
> >Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
> >Solution: microvm is now not build if only Xen is available.
> >
> >Signed-off-by: Will Gyda <vilhelmgyda@gmail.com>
> >
>
>
> I suggest rewording the commit title to something like
>
> "i386: remove microvm from default build"
>
> And adding a commit message that explains that the microvm does not work
> on Xen, hence if only Xen is available it should not be built.
>
> Also, you can add a
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2294
>
> line before your Signed-off-by. See
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html
>
> But, seeing the issue itself, it's about the microvm being stuck under
> Xen. So the commit that resolves this would either make it non-stuck or
> make it impossible to start the vm to begin with.
>
>
> >---
> > configs/devices/i386-softmmu/default.mak | 2 +-
> > hw/i386/Kconfig | 2 ++
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> >diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
> >index 598c6646df..6a73aee7dd 100644
> >--- a/configs/devices/i386-softmmu/default.mak
> >+++ b/configs/devices/i386-softmmu/default.mak
> >@@ -29,4 +29,4 @@
> > CONFIG_ISAPC=y
> > CONFIG_I440FX=y
> > CONFIG_Q35=y
> >-CONFIG_MICROVM=y
> >+#CONFIG_MICROVM=n
>
> Better remove this altogether since it's not a default anymore.
>
> >diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> >index a6ee052f9a..f8ec8ebd7a 100644
> >--- a/hw/i386/Kconfig
> >+++ b/hw/i386/Kconfig
> >@@ -108,6 +108,8 @@ config Q35
> >
> > config MICROVM
> > bool
> >+ default y
> >+ depends on KVM || WHPX || NVMM || HVF
>
> What about TCG? Will it be available if we only build with tcg?
>
> > select SERIAL_ISA # for serial_hds_isa_init()
> > select ISA_BUS
> > select APIC
> >--
> >2.25.1
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-29 10:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 10:23 [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64 Will Gyda
2024-05-29 7:07 ` Paolo Bonzini
2024-05-29 8:24 ` Vilhelm Gyda
2024-05-29 10:09 ` Manos Pitsidianakis
2024-05-29 10:12 ` Manos Pitsidianakis
2024-05-29 10:56 ` Vilhelm Gyda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).