From: Coco Li <lixiaoyan@google.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: peter.maydell@linaro.org, clg@kaod.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, Felix Wu <flwu@google.com>
Subject: Re: [PATCH 1/5] hw/gpio: Add property for ASPEED GPIO in 32 bits basis
Date: Fri, 12 Sep 2025 10:43:53 -0700 [thread overview]
Message-ID: <CADjXwjjjSQGwOfquXmLfENRAAmHv5KXaGvjkiK7KFzGuehPsow@mail.gmail.com> (raw)
In-Reply-To: <e0e733ff458cf253ddaf2b5570183b86c7c13102.camel@codeconstruct.com.au>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hello Andrew,
I discussed with the original author of the patch and the Nuvoton
functionality mentioned above has not been upstreamed since then,
unfortunately.
Aside from the comment above, we believe this patch series allows gpios to
be accessed more dynamically/flexibly in complicated simulation, and also
helps with accessing advanced gpio features, see the sgpio implementation
later in this patch series.
Best,
Coco
On Tue, Sep 9, 2025 at 8:52 PM Andrew Jeffery <andrew@codeconstruct.com.au>
wrote:
> On Wed, 2025-09-03 at 21:38 +0000, Coco Li wrote:
> > From: Felix Wu <flwu@google.com>
> >
> > Added 32 bits property for ASPEED GPIO. Previously it can only be access
> in bitwise manner.
> >
> > This change gives ASPEED similar behavior as Nuvoton.
>
> Can you point me to the Nuvoton functionality? I had a quick look and
> couldn't immediately see an equivalent implementation.
>
> Regardless, I'd like to see more motivation in the commit message than
> "make it behave like Nuvoton". Can you provide a concrete use-case as
> an example?
>
> Andrew
>
[-- Attachment #2: Type: text/html, Size: 1579 bytes --]
next prev parent reply other threads:[~2025-09-12 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 21:38 [PATCH 0/5] Add Aspeed GPIO test and Support Nuvoton Serial GPIO Expansion (SGPIO) device Coco Li
2025-09-03 21:38 ` [PATCH 1/5] hw/gpio: Add property for ASPEED GPIO in 32 bits basis Coco Li
2025-09-09 7:13 ` Cédric Le Goater
2025-09-10 3:51 ` Andrew Jeffery
2025-09-12 17:43 ` Coco Li [this message]
2025-09-18 0:59 ` Andrew Jeffery
2025-09-03 21:38 ` [PATCH 2/5] tests/qtest: Add qtest for for ASPEED GPIO gpio-set property Coco Li
2025-09-09 7:14 ` Cédric Le Goater
2025-09-03 21:38 ` [PATCH 3/5] hw/arm/npcm8xx.c: Add all IRQ ENUMs Coco Li
2025-09-03 21:38 ` [PATCH 4/5] hw/gpio/npcm8xx: Implement SIOX (SPGIO) device for NPCM without input pin logic Coco Li
2025-09-03 21:38 ` [PATCH 5/5] hw/gpio/npcm8xx: Implement npcm sgpio device " Coco Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADjXwjjjSQGwOfquXmLfENRAAmHv5KXaGvjkiK7KFzGuehPsow@mail.gmail.com \
--to=lixiaoyan@google.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=flwu@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).