Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2

["罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com> wrote:

> On 05/09/2020 08.38, Yonggang Luo wrote:
> > ../tests/test-vmstate.c: In function 'int_cmp':
> > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> >   884 |     uint ua = GPOINTER_TO_UINT(a);
> >       |     ^~~~
> >       |     uInt
> > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> >   885 |     uint ub = GPOINTER_TO_UINT(b);
> >       |     ^~~~
> >       |     uInt
> > make: ***
> [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> >  tests/test-vmstate.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> > index f7b3868881..f8de709a0b 100644
> > --- a/tests/test-vmstate.c
> > +++ b/tests/test-vmstate.c
> > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
> >  /* ID comparison function */
> >  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
> user_data)
> >  {
> > -    uint ua = GPOINTER_TO_UINT(a);
> > -    uint ub = GPOINTER_TO_UINT(b);
> > +    guint ua = GPOINTER_TO_UINT(a);
> > +    guint ub = GPOINTER_TO_UINT(b);
> >      return (ua > ub) - (ua < ub);
> >  }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Does this means quened or to be queued, if that's true, will skip this
next revision


-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

[-- Attachment #2: Type: text/html, Size: 2412 bytes --]