From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-level <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH 8/8] configure: automatically parse command line for meson -D options
Date: Fri, 22 Jan 2021 00:00:19 -0800 [thread overview]
Message-ID: <CAE2XoE9gag5J7reaQPaovto6HDvDPaGOJCSGeModiXVr5p7chg@mail.gmail.com> (raw)
In-Reply-To: <50a309ed-64a3-6d17-9edb-6274abb4e498@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
Hi Paolo, as python and meson are required dependencies to building qemu
now,
can we detecting python/meson at the very begining of configure,
even before the --help parameter.
On Wed, Jan 13, 2021 at 6:08 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 13/01/21 11:31, Daniel P. Berrangé wrote:
> >> meson-buildoptions.json | 717
++++++++++++++++++++++++
> > I'm not a fan of seeing this file introduced as it has significant
> > overlap with meson_options.txt. I feel like the latter has enough
> > information present to do an acceptable job for help output. After
> > all that's sufficient if we were using meson directly.
>
> Sorry, I missed this remark. meson-buildoptions.json is not
> hand-written. It is the result of Meson's own parsing meson_options.txt
> exported as JSON.
>
> In the commit message "because we parse command-line options before
> meson is available, the introspection output is stored in the source
> tree. This is the reason for the unattractive diffstat; the number of
> JSON lines added is higher than the number of configure lines removed.
> Of course the latter are code that must be maintained manually and the
> former is not".
>
> Paolo
>
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 1593 bytes --]
next prev parent reply other threads:[~2021-01-22 8:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 14:00 [RFC PATCH v2 0/8] Automatically convert configure options to meson build options Paolo Bonzini
2021-01-07 14:00 ` [PATCH 1/8] build-system: clean up TCG/TCI configury Paolo Bonzini
2021-01-07 15:01 ` Peter Maydell
2021-01-07 15:50 ` Paolo Bonzini
2021-01-07 16:06 ` Daniel P. Berrangé
2021-01-13 13:09 ` Philippe Mathieu-Daudé
2021-01-13 13:42 ` Helge Deller
2021-01-13 13:57 ` Daniel P. Berrangé
2021-01-13 14:23 ` Peter Maydell
2021-01-13 20:39 ` Helge Deller
2021-01-13 14:23 ` Helge Deller
2021-01-13 14:34 ` Paolo Bonzini
2021-01-13 15:37 ` Helge Deller
2021-01-14 9:51 ` John Paul Adrian Glaubitz
2021-01-13 14:02 ` John David Anglin
2021-01-13 15:00 ` John Paul Adrian Glaubitz
2021-01-07 14:00 ` [PATCH 2/8] cocoa: do not enable coreaudio automatically Paolo Bonzini
2021-01-07 14:00 ` [PATCH 3/8] gtk: remove CONFIG_GTK_GL Paolo Bonzini
2021-01-07 16:05 ` Gerd Hoffmann
2021-01-07 14:00 ` [PATCH 4/8] configure: move X11 detection to Meson Paolo Bonzini
2021-01-07 14:00 ` [PATCH 5/8] configure: move GTK+ " Paolo Bonzini
2021-01-07 14:00 ` [PATCH 6/8] configure: move Cocoa incompatibility checks " Paolo Bonzini
2021-01-07 14:00 ` [PATCH 7/8] configure: quote command line arguments in config.status Paolo Bonzini
2021-01-13 15:44 ` Eric Blake
2021-01-07 14:00 ` [PATCH 8/8] configure: automatically parse command line for meson -D options Paolo Bonzini
2021-01-13 10:31 ` Daniel P. Berrangé
2021-01-13 12:26 ` Paolo Bonzini
2021-01-13 14:04 ` Paolo Bonzini
2021-01-22 8:00 ` 罗勇刚(Yonggang Luo) [this message]
2021-01-22 20:43 ` Paolo Bonzini
2021-01-23 3:30 ` 罗勇刚(Yonggang Luo)
2021-01-23 18:00 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE9gag5J7reaQPaovto6HDvDPaGOJCSGeModiXVr5p7chg@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).