From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
qemu-level <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses
Date: Mon, 7 Sep 2020 12:20:24 +0800 [thread overview]
Message-ID: <CAE2XoE9qajeCRoVBZYBSYycdB-+j0fL2atfUjP-vkhXHhjp9tg@mail.gmail.com> (raw)
In-Reply-To: <b40c03d0-99bc-eb94-200f-7cf9a7734797@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On Sun, Sep 6, 2020 at 11:28 AM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 9/5/20 1:42 PM, Yonggang Luo wrote:
> > + nativecharset_to_ucs2 = iconv_open("UCS-2", g_get_codeset());
>
> g_get_codeset():
> "a newly allocated string containing the name of the character set. This
> string
> must be freed with g_free()."
>
> You need to plug the memory leak.
>
> It's probably worth fixing the mistake in which we call this function four
> times from the same function.
>
Done with autofree
>
>
> r~
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 1222 bytes --]
prev parent reply other threads:[~2020-09-07 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 20:42 [PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses Yonggang Luo
2020-09-06 3:28 ` Richard Henderson
2020-09-07 4:20 ` 罗勇刚(Yonggang Luo) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE9qajeCRoVBZYBSYycdB-+j0fL2atfUjP-vkhXHhjp9tg@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).