From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] configure: the error info not consistence with option.
Date: Sat, 5 Sep 2020 13:43:58 +0800 [thread overview]
Message-ID: <CAE2XoE_JJsrYW50_carvoUzj2fedwj1eCDrgpd3JY4bepF-auQ@mail.gmail.com> (raw)
In-Reply-To: <ddcf4e38-717e-87c1-46c3-89df8bc035c2@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Fri, Sep 4, 2020 at 3:54 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote:
> >
> > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
> > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no";
> > then
> > - error_exit "--enable-vhost-net-user requires
> --enable-vhost-user"
> > + error_exit "--enable-vhost-net requires --enable-vhost-user"
> > fi
> >
> >
> > This change seems wrong.
> >
> > I didn't found --enable-vhost-net-user option handling?
> > you may grep it?
> >
> >
>
> You're right, it is all dead code. The four lines are equivalent to
> just vhost_net_user=$vhost_user. You could also add
> --enable-vhost-net-user though!
>
I remove those four lines and use vhost_net_user=$vhost_user instead for
simplicity,
if we have no strong need of this option, i guess remove it are better
>
> Thanks,
>
> Paolo
>
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 1854 bytes --]
prev parent reply other threads:[~2020-09-05 5:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 22:06 [PATCH] configure: the error info not consistence with option Yonggang Luo
2020-09-04 0:18 ` Paolo Bonzini
2020-09-04 3:54 ` 罗勇刚(Yonggang Luo)
2020-09-04 7:54 ` Paolo Bonzini
2020-09-05 5:43 ` 罗勇刚(Yonggang Luo) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE_JJsrYW50_carvoUzj2fedwj1eCDrgpd3JY4bepF-auQ@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).