From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"QEMU Block" <qemu-block@nongnu.org>,
"Stefan Weil" <sw@weilnetz.de>, "Peter Lieven" <pl@kamp.de>,
qemu-level <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v5 03/11] ci: fixes msys2 build by upgrading capstone to 4.0.2
Date: Sat, 5 Sep 2020 21:22:45 +0800 [thread overview]
Message-ID: <CAE2XoE_VmhJWasoaZE93A6sJsLJABKNy11AD4hr3TCowex8OFA@mail.gmail.com> (raw)
In-Reply-To: <c71e8760-39d6-6448-40b2-ba4b2468d42b@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]
On Sat, Sep 5, 2020 at 7:14 PM Mark Cave-Ayland <
mark.cave-ayland@ilande.co.uk> wrote:
> On 05/09/2020 07:23, Yonggang Luo wrote:
>
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> > capstone | 2 +-
> > configure | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/capstone b/capstone
> > index 22ead3e0bf..1d23053284 160000
> > --- a/capstone
> > +++ b/capstone
> > @@ -1 +1 @@
> > -Subproject commit 22ead3e0bfdb87516656453336160e0a37b066bf
> > +Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1
> > diff --git a/configure b/configure
> > index 5d8bf4d8bb..f8cbd2898c 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5117,7 +5117,7 @@ case "$capstone" in
> > LIBCAPSTONE=libcapstone.a
> > fi
> > capstone_libs="-Lcapstone -lcapstone"
> > - capstone_cflags="-I${source_path}/capstone/include"
> > + capstone_cflags="-I${source_path}/capstone/include
> -I${source_path}/capstone/include/capstone"
> > ;;
> >
> > system)
>
> Just to reiterate from the other meson thread: the reason that the current
> capstone
> won't compile under Windows is due to
> https://bugs.launchpad.net/qemu/+bug/1826175.
>
> The merged fix from
>
> https://github.com/aquynh/capstone/commit/29893c63e34ee21846744d02c396ae3c801b936b
> is
> really quite simple - it might be that if upgrading is not an option then
> a suitable
> WIN32 configure hack could be used.
>
Who is responsible for capstone? Capstone is not a key component, just for
disassembly, the newest version would have more function i guess.
>
>
> ATB,
>
> Mark.
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 2787 bytes --]
next prev parent reply other threads:[~2020-09-05 13:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 6:23 [PATCH v5 00/11] Green the msys2 CI make Yonggang Luo
2020-09-05 6:23 ` [PATCH v5 01/11] Revert "configure: add --ninja option" Yonggang Luo
2020-09-05 8:29 ` Thomas Huth
2020-09-05 8:45 ` Mark Cave-Ayland
2020-09-05 8:48 ` Paolo Bonzini
2020-09-05 6:23 ` [PATCH v5 02/11] block: Fixes nfs on msys2/mingw Yonggang Luo
2020-09-05 6:23 ` [PATCH v5 03/11] ci: fixes msys2 build by upgrading capstone to 4.0.2 Yonggang Luo
2020-09-05 11:14 ` Mark Cave-Ayland
2020-09-05 13:22 ` 罗勇刚(Yonggang Luo) [this message]
2020-09-05 14:28 ` Peter Maydell
2020-09-05 6:23 ` [PATCH v5 04/11] meson: upgrade meson for execute custom ninjatool under msys2 properly Yonggang Luo
2020-09-05 13:44 ` Paolo Bonzini
2020-09-05 14:21 ` 罗勇刚(Yonggang Luo)
2020-09-05 6:23 ` [PATCH v5 05/11] ci: Enable msys2 ci in cirrus Yonggang Luo
2020-09-05 6:23 ` [PATCH v5 06/11] tests: Trying fixes test-replication.c on msys2 Yonggang Luo
2020-09-05 6:23 ` [PATCH v5 07/11] block: get file-win32.c handle locking option consistence with file-posix.c Yonggang Luo
2020-09-05 6:23 ` [PATCH v5 08/11] osdep: These function are only available on Non-Win32 system Yonggang Luo
2020-09-05 8:33 ` Thomas Huth
2020-09-07 17:42 ` 罗勇刚(Yonggang Luo)
2020-09-05 6:23 ` [PATCH v5 09/11] meson: Fixes qapi tests Yonggang Luo
2020-09-05 8:42 ` Thomas Huth
2020-09-07 4:20 ` 罗勇刚(Yonggang Luo)
2020-09-05 6:23 ` [PATCH v5 10/11] docker: Add win32/msys2/mingw64 docker Yonggang Luo
2020-09-05 6:23 ` [PATCH v5 11/11] ci: Enable Github actions Yonggang Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE_VmhJWasoaZE93A6sJsLJABKNy11AD4hr3TCowex8OFA@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).