From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.
Date: Fri, 16 Oct 2020 05:39:55 +0800 [thread overview]
Message-ID: <CAE2XoE_X_Ep43MvFGtBPR934oKofnWZhYvTA2ajbWhvbFnPxKA@mail.gmail.com> (raw)
In-Reply-To: <CABgObfYXes_WRnqkBs2-1cTQVRu5PMO1Wv9vguWxY_41aFzTfQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir
not used at all in configure,
On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Why?
>
> Paolo
>
> Il gio 15 ott 2020, 22:11 Yonggang Luo <luoyonggang@gmail.com> ha scritto:
>>
>> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
>> ---
>> configure | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index f839c2a557..1ce31f97b4 100755
>> --- a/configure
>> +++ b/configure
>> @@ -971,7 +971,7 @@ for opt do
>> ;;
>> --with-suffix=*) qemu_suffix="$optarg"
>> ;;
>> - --docdir=*) qemu_docdir="$optarg"
>> + --docdir=*) docdir="$optarg"
>> ;;
>> --sysconfdir=*) sysconfdir="$optarg"
>> ;;
>> @@ -5770,7 +5770,6 @@ fi
>> qemu_confdir="$sysconfdir/$qemu_suffix"
>> qemu_moddir="$libdir/$qemu_suffix"
>> qemu_datadir="$datadir/$qemu_suffix"
>> -qemu_docdir="$docdir/$qemu_suffix"
>> qemu_localedir="$datadir/locale"
>> qemu_icondir="$datadir/icons"
>> qemu_desktopdir="$datadir/applications"
>> --
>> 2.28.0.windows.1
>>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 1834 bytes --]
next prev parent reply other threads:[~2020-10-15 21:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 20:10 [PATCH v2 0/4] Fixes docs building on msys2/mingw Yonggang Luo
2020-10-15 20:10 ` [PATCH v2 1/4] docs: Fixes build docs " Yonggang Luo
2020-10-15 20:30 ` Peter Maydell
2020-10-15 20:38 ` 罗勇刚(Yonggang Luo)
2020-10-15 21:22 ` Paolo Bonzini
2020-10-15 21:33 ` 罗勇刚(Yonggang Luo)
2020-10-15 20:10 ` [PATCH v2 2/4] configure: the docdir option should passed to meson as is Yonggang Luo
2020-10-15 21:23 ` Paolo Bonzini
2020-10-15 21:39 ` 罗勇刚(Yonggang Luo) [this message]
2020-10-15 20:10 ` [PATCH v2 3/4] meson: Move the detection logic for sphinx to meson Yonggang Luo
2020-10-15 20:10 ` [PATCH v2 4/4] cirrus: Enable doc build on msys2/mingw Yonggang Luo
2020-10-15 21:52 ` [PATCH v2 0/4] Fixes docs building " Paolo Bonzini
2020-10-15 21:55 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE_X_Ep43MvFGtBPR934oKofnWZhYvTA2ajbWhvbFnPxKA@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).