Re: [PATCH v3 5/8] Add memory hardware address read/write API

[Rowan Hart <rowanbhart@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

>
>
> > This definition strikes me as odd. What was your reason to assert
> > `current_cpu` here, but not in the other two functions? Also a bit
> > surprising is the declaration of `cpu` if you use it in just one place
> > (rather than just use `current_cpu` directly as for the assertion).
> >
> > And there is no reason in particular why the vCPU could not be a
> > function parameter of `qemu_plugin_translate_vaddr`, right? You don't
> > have the same restrictions as in `qemu_plugin_read_memory_hwaddr` or
> > `qemu_plugin_hwaddr_operation_result` where you actually touch memory?
> >
>
> That's a good point, adding a "unsigned int vcpu_index" to the signature
> should be enough to query current or any other vcpu easily.
>
This is a really nice idea, it might be nice to make a vcpu version of
read/write register too. For memory, I'd think going with the current
memory is probably fine, I don't see any configs with different memory per
vcpu?

>

[-- Attachment #2: Type: text/html, Size: 1466 bytes --]