From: Kohei Tokunaga <ktokunaga.mail@gmail.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-s390x@nongnu.org, "Zhao Liu" <zhao1.liu@intel.com>,
"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
"Ed Maste" <emaste@freebsd.org>, "Paul Durrant" <paul@xen.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Thomas Huth" <thuth@redhat.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Gustavo Romero" <gustavo.romero@linaro.org>
Subject: Re: [PATCH 01/16] tests/docker: drop --link from COPYs in emsdk docker
Date: Thu, 13 Nov 2025 00:23:12 +0900 [thread overview]
Message-ID: <CAEDrbUbLNbTkVTYTnodZPXsPyBJ+ci9DoxLDyP8FRyf2u0QGgw@mail.gmail.com> (raw)
In-Reply-To: <20251111171724.78201-2-alex.bennee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]
> As we need to build images in both docker and podman lets not have any
> incompatibilities. I don't think it makes any major difference.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/dockerfiles/emsdk-wasm32-cross.docker | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/emsdk-wasm32-cross.docker
b/tests/docker/dockerfiles/emsdk-wasm32-cross.docker
> index 6b1642a207c..1f08eb0b855 100644
> --- a/tests/docker/dockerfiles/emsdk-wasm32-cross.docker
> +++ b/tests/docker/dockerfiles/emsdk-wasm32-cross.docker
> @@ -115,8 +115,8 @@ RUN mkdir -p /glib
> RUN curl -Lks
https://download.gnome.org/sources/glib/${GLIB_MINOR_VERSION}/glib-$GLIB_VERSION.tar.xz
| \
> tar xJC /glib --strip-components=1
>
> -COPY --link --from=zlib-dev /builddeps/ /builddeps/
> -COPY --link --from=libffi-dev /builddeps/ /builddeps/
> +COPY --from=zlib-dev /builddeps/ /builddeps/
> +COPY --from=libffi-dev /builddeps/ /builddeps/
>
> WORKDIR /glib
> RUN <<EOF
> @@ -141,5 +141,5 @@ RUN sed -i -E "/#define HAVE_PTHREAD_GETNAME_NP 1/d"
./_build/config.h
> RUN meson install -C _build
>
> FROM build-base
> -COPY --link --from=glib-dev /builddeps/ /builddeps/
> -COPY --link --from=pixman-dev /builddeps/ /builddeps/
> +COPY --from=glib-dev /builddeps/ /builddeps/
> +COPY --from=pixman-dev /builddeps/ /builddeps/
Reviewed-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Regards,
Kohei Tokunaga
[-- Attachment #2: Type: text/html, Size: 1959 bytes --]
next prev parent reply other threads:[~2025-11-12 15:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 17:17 [PATCH 00/16] testing/next cleanups (docker, functional) Alex Bennée
2025-11-11 17:17 ` [PATCH 01/16] tests/docker: drop --link from COPYs in emsdk docker Alex Bennée
2025-11-12 15:23 ` Kohei Tokunaga [this message]
2025-11-11 17:17 ` [PATCH 02/16] libvirt-ci: bump libvirt-ci to latest version Alex Bennée
2025-11-11 17:34 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 03/16] tests/lcitool: update ENV stazas outputted by refresh Alex Bennée
2025-11-11 17:35 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 04/16] tests/docker: add coreutils to the package list Alex Bennée
2025-11-11 17:36 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 05/16] gitlab: add initial ppc64le custom-runner test Alex Bennée
2025-11-11 17:38 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 06/16] docs/about/emulation: update assets for uftrace plugin documentation Alex Bennée
2025-11-12 1:38 ` Akihiko Odaki
2025-11-12 9:54 ` Alex Bennée
2025-11-12 10:15 ` Akihiko Odaki
2025-11-21 7:44 ` Philippe Mathieu-Daudé
2025-11-21 14:27 ` Pierrick Bouvier
2025-11-11 17:17 ` [PATCH 07/16] tests: move test_xen assets to share.linaro.org Alex Bennée
2025-11-11 18:01 ` Thomas Huth
2025-11-11 17:17 ` [PATCH 08/16] tests: move test_virt " Alex Bennée
2025-11-11 18:02 ` Thomas Huth
2025-11-11 17:17 ` [PATCH 09/16] tests: move test_netdev_ethtool " Alex Bennée
2025-11-11 18:10 ` Thomas Huth
2025-11-11 17:17 ` [PATCH 10/16] tests: move test_kvm_xen " Alex Bennée
2025-11-11 18:11 ` Thomas Huth
2025-11-11 17:17 ` [PATCH 11/16] tests: move test_kvm " Alex Bennée
2025-11-11 18:13 ` Thomas Huth
2025-11-11 17:17 ` [PATCH 12/16] tests: move test_virt_gpu " Alex Bennée
2025-11-11 18:00 ` Thomas Huth
2025-11-11 17:17 ` [PATCH 13/16] gitlab: use template for ubuntu-24.04-s390x jobs Alex Bennée
2025-11-11 17:44 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 14/16] gitlab: suppress custom runners being triggered by schedule Alex Bennée
2025-11-11 17:47 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 15/16] gitlab: make the schedule rules a bit more general Alex Bennée
2025-11-11 17:50 ` Daniel P. Berrangé
2025-11-11 17:17 ` [PATCH 16/16] gitlab: add a weekly container building job Alex Bennée
2025-11-11 17:49 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEDrbUbLNbTkVTYTnodZPXsPyBJ+ci9DoxLDyP8FRyf2u0QGgw@mail.gmail.com \
--to=ktokunaga.mail@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=dmitry.osipenko@collabora.com \
--cc=dwmw2@infradead.org \
--cc=emaste@freebsd.org \
--cc=gustavo.romero@linaro.org \
--cc=lwhsu@freebsd.org \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=sriram.yagnaraman@ericsson.com \
--cc=thuth@redhat.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).