From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJjgA-0004FX-A3 for qemu-devel@nongnu.org; Fri, 28 Oct 2011 06:28:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJjg5-0003Xg-3x for qemu-devel@nongnu.org; Fri, 28 Oct 2011 06:28:50 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:52526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJjg4-0003Xc-VC for qemu-devel@nongnu.org; Fri, 28 Oct 2011 06:28:45 -0400 Received: by vcbfl17 with SMTP id fl17so3712766vcb.4 for ; Fri, 28 Oct 2011 03:28:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4EA81C05.5090002@redhat.com> <4EA82BAA.10207@redhat.com> <4EA84115.9090707@redhat.com> <20111027071741.GC32287@stefanha-thinkpad.localdomain> <4EA9A9AA.9060208@redhat.com> <4EAA1184.4000004@redhat.com> Date: Fri, 28 Oct 2011 18:28:44 +0800 Message-ID: From: Zhi Yong Wu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lucas Meneghel Rodrigues Cc: Kevin Wolf , KVM mailing list , Stefan Hajnoczi , Marcelo Tosatti , QEMU devel , Avi Kivity , Cleber Rosa , Richard Henderson On Fri, Oct 28, 2011 at 6:24 PM, Zhi Yong Wu wrote: > On Fri, Oct 28, 2011 at 10:20 AM, Lucas Meneghel Rodrigues > wrote: >> On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote: >>> >>> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues >>> =A0wrote: >>>> >>>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote: >>>>> >>>>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues >>>>> wrote: >>>>>> >>>>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote: >>>>>>> >>>>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: >>>>>>>> >>>>>>>> Hi folks: >>>>>>>> >>>>>>>> We've captured a regression with floppy disk on recent qemu (and >>>>>>>> qemu-kvm, after a code merge). We bisected it to be caused by: >>>>>>>> >>>>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 >>>>>>>> Author: Richard Henderson >>>>>>>> Date: =A0 Mon Aug 15 15:08:45 2011 -0700 >>>>>>>> >>>>>>>> =A0 =A0 =A0fdc: Convert to isa_register_portio_list >>>>>>>> >>>>>>>> =A0 =A0 =A0Signed-off-by: Richard Henderson >>>>>>>> =A0 =A0 =A0Signed-off-by: Avi Kivity >>>>>>>> >>>>>>>> Since this commit, the guest doesn't see a floppy disk attached to= it >>>>>>>> anymore, blocking kvm autotest ability to install windows guests >>>>>>>> automatically. This is a big deal for kvm autotest (ruins our >>>>>>>> automated >>>>>>>> regression jobs), so please take a look at it. >>>>>>> >>>>>>> Can you please try again with the latest block branch? I think ther= e >>>>>>> is >>>>>>> a patch queued that will fix it. >>>>>> >>>>>> Kevin, I did try with HEAD of your repo: >>>>>> >>>>>> git://repo.or.cz/qemu/kevin.git >>>>>> >>>>>> [lmr@freedom qemu-kwolf]$ git branch -r >>>>>> =A0 origin/HEAD -> =A0 =A0origin/master >>>>>> =A0 origin/blkqueue >>>>>> =A0 origin/blkqueue-v1 >>>>>> =A0 origin/block >>>>>> =A0 origin/coroutine >>>>>> =A0 origin/coroutine-block >>>>>> =A0 origin/coroutine-devel >>>>>> =A0 origin/devel >>>>>> =A0 origin/ehci >>>>>> =A0 origin/for-anthony >>>>>> =A0 origin/for-stable-0.14 >>>>>> =A0 origin/inplace-conversion >>>>>> =A0 origin/master >>>>>> >>>>>> With this repo, master branch, the problem persists. With the block >>>>>> branch, the problem persists. >>>>>> >>>>>> Now, with the blkqueue branch the problem is resolved. Cleber had >>>>>> the same results booting a FreeDOS floppy. So the fix is indeed in >>>>>> blkqueue. >>>>>> >>>>>> Oh, you might want to check the blkqueue branch, it does have quite >>>>>> a bunch of set but unused variables, which will cause compilation >>>>>> errors unless --disable-werror is passed to the configure script. >>>>> >>>>> I think blkqueue is an older development branch of the "block queue" >>>>> feature that Kevin was working on. =A0It is not Kevin's block tree (s= ee >>>>> his "block" branch). >>>> >>>> So no, the block branch does not resolve the floppy access problem. >>>> >>>> Well, considering the tests of the stable set I'm running against qemu >>>> right >>>> now, this is not the biggest of our problems... I'm verifying qemu is >>>> segfaulting on nearly every prolonged attempt of doing migration... I'= m >>>> about to write an email about it. >>> >>> What is the OS of your guest? fedora16 or RHEL6? I would like recently >>> to use floppy device in guest. >> >> Fedora 15. And on one host with OS Fedora 15, after floppy.ko is loaded, i have not seen its device file /dev/fd0. On one guest with RH6 or Fedora 14, it fails to load floppy.ko. > Just i tried to use Fedora-15-x86_64-DVD.iso to install one guest, but = =A0hang up. > > My qemu.git/HEAD is 9f60639b848944200c3d33a89233d808de0b5a43. > > While it can work when using ./Fedora-14-x86_64-DVD.iso. > >>Regards, >> > > > > -- > Regards, > > Zhi Yong Wu > --=20 Regards, Zhi Yong Wu