From: Zhi Yong Wu <zwu.kernel@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, wuzhy@linux.vnet.ibm.com,
qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 2/2] block: disable I/O throttling on sync api
Date: Sat, 31 Mar 2012 20:09:46 +0800 [thread overview]
Message-ID: <CAEH94LjFH7nDat_8wHqf005tF8cz3Rprpaj=SEOSh-3i_gV7Rw@mail.gmail.com> (raw)
In-Reply-To: <CAJSP0QVxHDZAvzwgUAzVSo8V3bmahZO4dXczZYWCS5VkYNCRFA@mail.gmail.com>
On Fri, Mar 30, 2012 at 6:29 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Fri, Mar 30, 2012 at 9:50 AM, <zwu.kernel@gmail.com> wrote:
>> + * When all sync I/O drivers are converted to async I/O, it will be restored
>> + * to the original state.
>
> The problem here is that guess_disk_lchs() uses bdrv_read(), not
> whether device emulation uses sync or async I/O. Converting devices
> to async I/O will not fix this.
By the way, when you did testing, you applied #1 of this patchset? I
think that it make sense for that assert issue to be fixed.
>
> Stefan
--
Regards,
Zhi Yong Wu
next prev parent reply other threads:[~2012-03-31 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 8:50 [Qemu-devel] [PATCH v3 2/2] block: disable I/O throttling on sync api zwu.kernel
2012-03-30 10:29 ` Stefan Hajnoczi
2012-03-31 12:07 ` Zhi Yong Wu
2012-04-02 7:31 ` Stefan Hajnoczi
2012-03-31 12:09 ` Zhi Yong Wu [this message]
2012-04-02 7:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEH94LjFH7nDat_8wHqf005tF8cz3Rprpaj=SEOSh-3i_gV7Rw@mail.gmail.com' \
--to=zwu.kernel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).