From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDx7u-0004gh-3Q for qemu-devel@nongnu.org; Sat, 31 Mar 2012 08:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDx7s-0007xT-Ff for qemu-devel@nongnu.org; Sat, 31 Mar 2012 08:09:49 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:64777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDx7s-0007xH-6y for qemu-devel@nongnu.org; Sat, 31 Mar 2012 08:09:48 -0400 Received: by pbcuo5 with SMTP id uo5so3191634pbc.4 for ; Sat, 31 Mar 2012 05:09:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1333097427-20912-1-git-send-email-zwu.kernel@gmail.com> Date: Sat, 31 Mar 2012 20:09:46 +0800 Message-ID: From: Zhi Yong Wu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/2] block: disable I/O throttling on sync api List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, wuzhy@linux.vnet.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Fri, Mar 30, 2012 at 6:29 PM, Stefan Hajnoczi wrote= : > On Fri, Mar 30, 2012 at 9:50 AM, =A0 wrote: >> + =A0 =A0 * When all sync I/O drivers are converted to async I/O, it wil= l be restored >> + =A0 =A0 * to the original state. > > The problem here is that guess_disk_lchs() uses bdrv_read(), not > whether device emulation uses sync or async I/O. =A0Converting devices > to async I/O will not fix this. By the way, when you did testing, you applied #1 of this patchset? I think that it make sense for that assert issue to be fixed. > > Stefan --=20 Regards, Zhi Yong Wu