From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zwu.kernel@gmail.com>) id 1SdB7c-0001gf-Vq
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 22:09:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zwu.kernel@gmail.com>) id 1SdB7b-00020q-7q
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 22:09:48 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:47387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zwu.kernel@gmail.com>) id 1SdB7b-00020l-0D
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 22:09:47 -0400
Received: by obbwd20 with SMTP id wd20so3518902obb.4
	for <qemu-devel@nongnu.org>; Fri, 08 Jun 2012 19:09:45 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAJSP0QUJY58ju1q-yO=qeSMtBoocpedqypGGQpLBrvP51BTNdA@mail.gmail.com>
References: <1339080860-16036-1-git-send-email-zwu.kernel@gmail.com>
	<CAJSP0QWvr+P=H-3KZ3imt+SRzeOhNFnwJ68-g8U3R86OC6Zgug@mail.gmail.com>
	<CAEH94Lh0isYCT-ZPq15z-fLpKig-gPv8jT6EU0Z9k6f0Fh1_LA@mail.gmail.com>
	<CAJSP0QUJY58ju1q-yO=qeSMtBoocpedqypGGQpLBrvP51BTNdA@mail.gmail.com>
Date: Sat, 9 Jun 2012 10:09:44 +0800
Message-ID: <CAEH94LjFZFEXXBpWYmhczx0SP4LZU97DiuwazhoV-i4w2skawQ@mail.gmail.com>
From: Zhi Yong Wu <zwu.kernel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev
 socket, listen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: pbonzini@redhat.com, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Fri, Jun 8, 2012 at 11:59 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote=
:
> On Fri, Jun 8, 2012 at 3:54 PM, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
>> On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi <stefanha@gmail.com> wro=
te:
>>> On Thu, Jun 7, 2012 at 3:54 PM, =A0<zwu.kernel@gmail.com> wrote:
>>>> @@ -86,7 +82,16 @@ static void net_socket_send(void *opaque)
>>>> =A0 =A0 =A0 =A0 /* end of connection */
>>>> =A0 =A0 eoc:
>>>> =A0 =A0 =A0 =A0 qemu_set_fd_handler(s->fd, NULL, NULL, NULL);
>>>> + =A0 =A0 =A0 =A0qemu_set_fd_handler(s->listen_fd, net_socket_accept, =
NULL, s);
>>>
>>> What happens when this is not a listen socket? =A0I suggest setting
>>> listen_fd to -1 during creation and not calling qemu_set_fd_handler()
>>> when listen_fd is -1 here. =A0If listen_fd is 0 then we'll register
>>> net_socket_accept when standard input becomes ready!
>>>
>>>> =A0 =A0 =A0 =A0 closesocket(s->fd);
>>>> +
>>>> + =A0 =A0 =A0 =A0s->fd =3D 0;
>>>
>>> -1 should be used since 0 is a valid file descriptor (standard input).
>> I think that s->fd =3D 0 doesn't cause every issue. When it is zero,
>> this fd hasn't been registered with every handler. You can see that
>> "qemu_set_fd_handler(s->fd, NULL, NULL, NULL);" before "s->fd =3D 0".
>
> If s->fd =3D 0 because we are still listening and net_socket_cleanup()
OK, done. any other issue?
> is called we will close() standard input.
>
> Stefan



--=20
Regards,

Zhi Yong Wu