* [PATCH v2] hw/block: m25p80: Support fast read for SST flashes
@ 2021-03-06 6:01 Bin Meng
2021-03-11 8:18 ` Bin Meng
2021-03-22 15:17 ` Alistair Francis
0 siblings, 2 replies; 5+ messages in thread
From: Bin Meng @ 2021-03-06 6:01 UTC (permalink / raw)
To: Alistair Francis; +Cc: Bin Meng, qemu-devel, qemu-block
From: Bin Meng <bin.meng@windriver.com>
Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
the address bytes. Note only SPI mode is supported by SST flashes.
[1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
---
Changes in v2:
- rebase on qemu/master
hw/block/m25p80.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 5f9471d83c..183d3f44c2 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -895,6 +895,9 @@ static void decode_fast_read_cmd(Flash *s)
s->needed_bytes = get_addr_length(s);
switch (get_man(s)) {
/* Dummy cycles - modeled with bytes writes instead of bits */
+ case MAN_SST:
+ s->needed_bytes += 1;
+ break;
case MAN_WINBOND:
s->needed_bytes += 8;
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] hw/block: m25p80: Support fast read for SST flashes
2021-03-06 6:01 [PATCH v2] hw/block: m25p80: Support fast read for SST flashes Bin Meng
@ 2021-03-11 8:18 ` Bin Meng
2021-03-16 1:39 ` Bin Meng
2021-03-22 15:17 ` Alistair Francis
1 sibling, 1 reply; 5+ messages in thread
From: Bin Meng @ 2021-03-11 8:18 UTC (permalink / raw)
To: Alistair Francis; +Cc: Bin Meng, qemu-devel@nongnu.org Developers, Qemu-block
On Sat, Mar 6, 2021 at 2:01 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
> the address bytes. Note only SPI mode is supported by SST flashes.
>
> [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Acked-by: Alistair Francis <alistair.francis@wdc.com>
>
> ---
>
> Changes in v2:
> - rebase on qemu/master
>
> hw/block/m25p80.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Ping?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/block: m25p80: Support fast read for SST flashes
2021-03-11 8:18 ` Bin Meng
@ 2021-03-16 1:39 ` Bin Meng
2021-03-22 1:29 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2021-03-16 1:39 UTC (permalink / raw)
To: Alistair Francis; +Cc: Bin Meng, qemu-devel@nongnu.org Developers, Qemu-block
On Thu, Mar 11, 2021 at 4:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Sat, Mar 6, 2021 at 2:01 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > From: Bin Meng <bin.meng@windriver.com>
> >
> > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
> > the address bytes. Note only SPI mode is supported by SST flashes.
> >
> > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf
> >
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > Acked-by: Alistair Francis <alistair.francis@wdc.com>
> >
> > ---
> >
> > Changes in v2:
> > - rebase on qemu/master
> >
> > hw/block/m25p80.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
>
> Ping?
Ping?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/block: m25p80: Support fast read for SST flashes
2021-03-16 1:39 ` Bin Meng
@ 2021-03-22 1:29 ` Bin Meng
0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2021-03-22 1:29 UTC (permalink / raw)
To: Alistair Francis; +Cc: Bin Meng, qemu-devel@nongnu.org Developers, Qemu-block
On Tue, Mar 16, 2021 at 9:39 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, Mar 11, 2021 at 4:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > On Sat, Mar 6, 2021 at 2:01 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > From: Bin Meng <bin.meng@windriver.com>
> > >
> > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
> > > the address bytes. Note only SPI mode is supported by SST flashes.
> > >
> > > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf
> > >
> > > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > > Acked-by: Alistair Francis <alistair.francis@wdc.com>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > - rebase on qemu/master
> > >
> > > hw/block/m25p80.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> >
> > Ping?
>
> Ping?
Ping?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/block: m25p80: Support fast read for SST flashes
2021-03-06 6:01 [PATCH v2] hw/block: m25p80: Support fast read for SST flashes Bin Meng
2021-03-11 8:18 ` Bin Meng
@ 2021-03-22 15:17 ` Alistair Francis
1 sibling, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2021-03-22 15:17 UTC (permalink / raw)
To: Bin Meng
Cc: Bin Meng, Alistair Francis, qemu-devel@nongnu.org Developers,
Qemu-block
On Sat, Mar 6, 2021 at 1:02 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
> the address bytes. Note only SPI mode is supported by SST flashes.
>
> [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Acked-by: Alistair Francis <alistair.francis@wdc.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
>
> ---
>
> Changes in v2:
> - rebase on qemu/master
>
> hw/block/m25p80.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 5f9471d83c..183d3f44c2 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -895,6 +895,9 @@ static void decode_fast_read_cmd(Flash *s)
> s->needed_bytes = get_addr_length(s);
> switch (get_man(s)) {
> /* Dummy cycles - modeled with bytes writes instead of bits */
> + case MAN_SST:
> + s->needed_bytes += 1;
> + break;
> case MAN_WINBOND:
> s->needed_bytes += 8;
> break;
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-22 15:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-06 6:01 [PATCH v2] hw/block: m25p80: Support fast read for SST flashes Bin Meng
2021-03-11 8:18 ` Bin Meng
2021-03-16 1:39 ` Bin Meng
2021-03-22 1:29 ` Bin Meng
2021-03-22 15:17 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).