qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Bin Meng <bin.meng@windriver.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] util/main-loop: Fix maximum number of wait objects for win32
Date: Wed, 10 Aug 2022 00:38:56 +0800	[thread overview]
Message-ID: <CAEUhbmVM8V-bcSjuXmH231zeXJe4UsQN0c+U-_MvoXtwFSL1xw@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CK5Di14cxc8t67bw9hyCoqWKz62m6j-m4OMqh31trrW=w@mail.gmail.com>

On Tue, Aug 9, 2022 at 9:15 PM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Fri, Aug 5, 2022 at 6:57 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> From: Bin Meng <bin.meng@windriver.com>
>>
>> The maximum number of wait objects for win32 should be
>> MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1.
>>
>> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
>
> Nack,
>
> if wait_objects.num reaches MAXIMUM_WAIT_OBJECTS,
>
> then qemu_del_wait_object() will iterate up to it, and then the branch "if (found)" will access the arrays at position i+1 == MAXIMUM_WAIT_OBJECTS.
>
> Note that the add functions should probably learn to avoid adding the same HANDLE twice, otherwise del is a bit broken.
>

Thanks for the review. Will fix in v2.

Regards,
Bin


      reply	other threads:[~2022-08-09 16:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 14:56 [PATCH 1/2] util/main-loop: Fix maximum number of wait objects for win32 Bin Meng
2022-08-05 14:56 ` [PATCH 2/2] util/aio-win32: Correct the event array size in aio_poll() Bin Meng
2022-08-05 15:09   ` Stefan Weil via
2022-08-09 16:38     ` Bin Meng
2022-08-08 15:53 ` [PATCH 1/2] util/main-loop: Fix maximum number of wait objects for win32 Bin Meng
2022-08-08 22:00   ` Philippe Mathieu-Daudé via
2022-08-09 13:15 ` Marc-André Lureau
2022-08-09 16:38   ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmVM8V-bcSjuXmH231zeXJe4UsQN0c+U-_MvoXtwFSL1xw@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=bin.meng@windriver.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).