qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Atish Patra <atish.patra@wdc.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alexander Richardson <Alexander.Richardson@cl.cam.ac.uk>,
	Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v3 1/3] riscv: Unify Qemu's reset vector code path
Date: Fri, 26 Jun 2020 18:25:39 +0800	[thread overview]
Message-ID: <CAEUhbmVQmS0v4WGEZAqeKpD0WwMUfdmLGqH6QQLo-_MS0AtZ7w@mail.gmail.com> (raw)
In-Reply-To: <20200626003313.715355-2-atish.patra@wdc.com>

On Fri, Jun 26, 2020 at 8:33 AM Atish Patra <atish.patra@wdc.com> wrote:
>
> Currently, all riscv machines except sifive_u have identical reset vector
> code implementations with memory addresses being different for all machines.
> They can be easily combined into a single function in common code.
>
> Move it to common function and let all the machines use the common function.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  hw/riscv/boot.c         | 45 +++++++++++++++++++++++++++++++++++++++++
>  hw/riscv/sifive_u.c     |  1 -
>  hw/riscv/spike.c        | 41 +++----------------------------------
>  hw/riscv/virt.c         | 40 +++---------------------------------
>  include/hw/riscv/boot.h |  2 ++
>  5 files changed, 53 insertions(+), 76 deletions(-)
>

Reviewed-by: Bin Meng <bin.meng@windriver.com>
Tested-by: Bin Meng <bin.meng@windriver.com>


  reply	other threads:[~2020-06-26 10:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  0:33 [PATCH v3 0/3] Add OpenSBI dynamic firmware support Atish Patra
2020-06-26  0:33 ` [PATCH v3 1/3] riscv: Unify Qemu's reset vector code path Atish Patra
2020-06-26 10:25   ` Bin Meng [this message]
2020-06-26  0:33 ` [PATCH v3 2/3] RISC-V: Copy the fdt in dram instead of ROM Atish Patra
2020-06-26 11:49   ` Bin Meng
2020-06-26 16:58     ` Atish Patra
2020-06-27  2:54       ` Bin Meng
2020-06-27  4:37         ` Atish Patra
2020-06-27  5:22           ` Alistair Francis
2020-06-27  9:55           ` Bin Meng
2020-06-27 10:03             ` Bin Meng
2020-06-29 18:50             ` Atish Patra
2020-06-30  1:04               ` Bin Meng
2020-06-26  0:33 ` [PATCH v3 3/3] riscv: Add opensbi firmware dynamic support Atish Patra
2020-06-26 12:17   ` Bin Meng
2020-06-26 18:48     ` Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmVQmS0v4WGEZAqeKpD0WwMUfdmLGqH6QQLo-_MS0AtZ7w@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=Alexander.Richardson@cl.cam.ac.uk \
    --cc=alistair.francis@wdc.com \
    --cc=atish.patra@wdc.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).