From: Bin Meng <bmeng.cn@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] tests/unit/test-image-locking: Fix handling of temporary files
Date: Wed, 12 Oct 2022 20:59:03 +0800 [thread overview]
Message-ID: <CAEUhbmXBcQBPGjtdLn_zWmtJbVXWkzOPzr5r_k4DjmzUXP-dvw@mail.gmail.com> (raw)
In-Reply-To: <20221012085932.799221-1-thuth@redhat.com>
On Wed, Oct 12, 2022 at 4:59 PM Thomas Huth <thuth@redhat.com> wrote:
>
> test-image-locking leaves some temporary files around - clean
> them up. While we're at it, test-image-locking is a unit test,
> so it should not use "qtest.*" for temporary file names. Give
> them better names instead, so that it clear where the temporary
> files come from.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/unit/test-image-locking.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Fixes: aef96d7d4f0b ("tests: Add unit tests for image locking")
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
prev parent reply other threads:[~2022-10-12 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 8:59 [PATCH] tests/unit/test-image-locking: Fix handling of temporary files Thomas Huth
2022-10-12 9:21 ` Marc-André Lureau
2022-10-12 9:46 ` Thomas Huth
2022-10-12 12:59 ` Bin Meng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmXBcQBPGjtdLn_zWmtJbVXWkzOPzr5r_k4DjmzUXP-dvw@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=fam@euphon.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).