From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <haris.phnx@gmail.com>) id 1axAIt-0001VI-JI
	for qemu-devel@nongnu.org; Mon, 02 May 2016 05:38:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <haris.phnx@gmail.com>) id 1axAIi-0004iu-3U
	for qemu-devel@nongnu.org; Mon, 02 May 2016 05:38:06 -0400
MIME-Version: 1.0
In-Reply-To: <20160430104800.0a7c1d11@kryten>
References: <20160404164457.539a55f0@kryten> <57021123.6050506@ozlabs.ru>
	<20160404204346.1cf44df8@kryten> <20160404210928.0d9ae644@kryten>
	<F99A6122-6B6D-45A3-99E2-2F56F143FB50@suse.de>
	<20160430104800.0a7c1d11@kryten>
From: haris iqbal <haris.phnx@gmail.com>
Date: Mon, 2 May 2016 15:06:46 +0530
Message-ID: <CAE_WKMzvsRzqiEXV4HsmLZ5D7jLtB+tWVo7UzhtJ9_GMC9Yicg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2] spapr: Don't set the TM ibm,
 pa-features bit in PR KVM mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anton Blanchard <anton@samba.org>
Cc: Alexander Graf <agraf@suse.de>, Michael Neuling <mikey@neuling.org>, Alexey Kardashevskiy <aik@ozlabs.ru>, Michael Ellerman <mpe@ellerman.id.au>, QEMU Developers <qemu-devel@nongnu.org>, Paul Mackerras <paulus@samba.org>, qemu-ppc@nongnu.org, linuxppc-dev@lists.ozlabs.org, David Gibson <david@gibson.dropbear.id.au>

On Sat, Apr 30, 2016 at 6:18 AM, Anton Blanchard <anton@samba.org> wrote:
> We don't support transactional memory in PR KVM, so don't tell
> the OS that we do.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> v2: Fix build with CONFIG_KVM disabled, noticed by Alex.
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index b69995e..dc3e3c9 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -696,6 +696,14 @@ static void spapr_populate_cpu_dt(CPUState *cs, void *fdt, int offset,
>      } else /* env->mmu_model == POWERPC_MMU_2_07 */ {
>          pa_features = pa_features_207;
>          pa_size = sizeof(pa_features_207);
> +
> +#ifdef CONFIG_KVM
> +        /* Don't enable TM in PR KVM mode */
> +        if (kvm_enabled() &&
> +            kvm_vm_check_extension(cs->kvm_state, KVM_CAP_PPC_GET_PVINFO)) {
> +            pa_features[24] &= ~0x80;
> +        }
> +#endif
>      }
>      if (env->ci_large_pages) {
>          pa_features[3] |= 0x20;
>

This email was put in the spam folder by gmail. The message said "It
has a from address in samba.org but has failed samba.org's required
tests for authentication". Just bringing this to peoples attention. I
thought a patch might go unnoticed else.

-- 

With regards,

Md Haris Iqbal,
Placement Coordinator, MTech IT
NITK Surathkal,
Contact: +91 8861996962