From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelioremonda@gmail.com>) id 1YyJpG-0004hS-8e
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:55:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelioremonda@gmail.com>) id 1YyJpF-0007a1-6d
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:55:50 -0400
Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:34740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelioremonda@gmail.com>) id 1YyJpE-0007Zt-OR
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:55:48 -0400
Received: by oifu123 with SMTP id u123so55578323oif.1
	for <qemu-devel@nongnu.org>; Fri, 29 May 2015 05:55:48 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAF3C4AD-953F-4A50-AAF1-52B2136CB5AB@livius.net>
References: <1432847398-9969-1-git-send-email-aurelioremonda@gmail.com>
	<CAF3C4AD-953F-4A50-AAF1-52B2136CB5AB@livius.net>
Date: Fri, 29 May 2015 09:55:48 -0300
Message-ID: <CAE_j2psCPEpmF__QNU-kAH2EVT1HX9MAq7_RPYqvWaT583ifFg@mail.gmail.com>
From: aurelio remonda <aurelioremonda@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liviu Ionescu <ilg@livius.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, Daniel Gutson <daniel.gutson@tallertechnologies.com>, qemu-devel@nongnu.org, Martin Galvan <martin.galvan@tallertechnologies.com>

2015-05-28 18:22 GMT-03:00 Liviu Ionescu <ilg@livius.net>:
> > On 29 May 2015, at 00:09, Aurelio C. Remonda <aurelioremonda@gmail.com> wrote:
> > The optional FPU in the M4 could be added in the future as a "Cortex-M4F" CPU.
>
> in my implementation I had a single name ("cortex-m4") and some flags, but a separate name is probably better. can we reserve
>
>         { .name = "cortex-m4f", ... }
>
> for this purpose?

Thanks for the feedback! Yes, we could but I think its outside of the
scope of this particular contribution.

> > All we'd have to do is add the ARM_FEATURE_VFP4 to the initfn.
>
> if it is that simple, why don't we add it in for now?

As Peter said, it may not actually be that simple.

Perhaps we could commit this now and add the VFP in the future?