From: Doug Gale <doug16k@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers
Date: Fri, 25 Jan 2019 20:57:02 -0330 [thread overview]
Message-ID: <CAEfK_44+aLer5OoaE__XWmvyiPdRvxOt=FM4pTBApwEqUns4fg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9AhBLS4J+bsv_srq0qw1PXeUF346Y_J0cujgfH+tFOJg@mail.gmail.com>
On Fri, Jan 25, 2019 at 6:22 AM Peter Maydell <peter.maydell@linaro.org>
wrote:
>
> Thanks for this explanation -- the patch makes a lot more sense with it.
> I'm confused though -- the XML we ship is basically what gdb itself
> ships and uses internally:
>
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/features/i386/i386.xml;h=beb1496d9773efcf0e0526dc540a5e206a2e21fc;hb=HEAD
>
> and that uses xi:include to pull in the other files.
> So it seems odd that gdb can't parse the XML it is using
> itself internally. Maybe QEMU is doing something else wrong
> somewhere?
>
>
I thought that too. I implemented gdbstub tracing a while ago and had it
enabled (-trace gdb*). The binary data it sends is exactly what I expect.
When I break into gdb, I checked the data and it looked correct. debug_xml
even prints out what it's going to parse. Looks fine. GDB calls into an XML
parser library, which I don't have built from source, so I didn't find
precisely where it fails, only the high level log showing unexpected
elements at nested feature.
next prev parent reply other threads:[~2019-01-26 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 4:04 [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers Doug Gale
2019-01-24 10:13 ` Peter Maydell
2019-01-24 20:29 ` Doug Gale
2019-01-25 1:22 ` Doug Gale
2019-01-25 9:52 ` Peter Maydell
2019-01-26 0:27 ` Doug Gale [this message]
2019-01-28 9:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEfK_44+aLer5OoaE__XWmvyiPdRvxOt=FM4pTBApwEqUns4fg@mail.gmail.com' \
--to=doug16k@gmail.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).