[Qemu-devel] PL022 VMSD versions bump

[Qemu-devel] PL022 VMSD versions bump

[Peter Crosthwaite]

Hi Peter,

Im looking to do some cleanup around pl022 and I would like to use it
as my lead example of code using the new generic FIFO (as I think I
have test cases handy for it). But the VMSD description for this
device is a bit ugly as it is:

        VMSTATE_INT32(tx_fifo_head, PL022State),
        VMSTATE_INT32(rx_fifo_head, PL022State),
        VMSTATE_INT32(tx_fifo_len, PL022State),
        VMSTATE_INT32(rx_fifo_len, PL022State),
        VMSTATE_UINT16(tx_fifo[0], PL022State),
        VMSTATE_UINT16(rx_fifo[0], PL022State),
        VMSTATE_UINT16(tx_fifo[1], PL022State),
        VMSTATE_UINT16(rx_fifo[1], PL022State),
        VMSTATE_UINT16(tx_fifo[2], PL022State),
        VMSTATE_UINT16(rx_fifo[2], PL022State),
        VMSTATE_UINT16(tx_fifo[3], PL022State),
        VMSTATE_UINT16(rx_fifo[3], PL022State),
        VMSTATE_UINT16(tx_fifo[4], PL022State),
        VMSTATE_UINT16(rx_fifo[4], PL022State),
        VMSTATE_UINT16(tx_fifo[5], PL022State),
        VMSTATE_UINT16(rx_fifo[5], PL022State),
        VMSTATE_UINT16(tx_fifo[6], PL022State),
        VMSTATE_UINT16(rx_fifo[6], PL022State),
        VMSTATE_UINT16(tx_fifo[7], PL022State),
        VMSTATE_UINT16(rx_fifo[7], PL022State),

There is a way to covert to Fifo while maintaining full backwards
compat (in much the same way as I did for serial), although as you can
imagine, it will be messy. Is it worth the VMSD version bump to get it
cleaned up?

Regards,
Peter

Re: [Qemu-devel] PL022 VMSD versions bump

[Peter Maydell]

On 9 April 2014 13:42, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> Hi Peter,
>
> Im looking to do some cleanup around pl022 and I would like to use it
> as my lead example of code using the new generic FIFO (as I think I
> have test cases handy for it). But the VMSD description for this
> device is a bit ugly as it is:

This will just be because it's a transliteration of a previous
save/load function implementation.

> There is a way to covert to Fifo while maintaining full backwards
> compat (in much the same way as I did for serial), although as you can
> imagine, it will be messy. Is it worth the VMSD version bump to get it
> cleaned up?

A version bump is fine with me.

thanks
-- PMM