From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WXrpv-0002sN-Sb
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 08:42:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WXrpp-0004Gz-Od
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 08:42:39 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:63341)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WXrpp-0004Gr-IX
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 08:42:33 -0400
Received: by mail-wi0-f174.google.com with SMTP id d1so8808870wiv.13
	for <qemu-devel@nongnu.org>; Wed, 09 Apr 2014 05:42:32 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
Date: Wed, 9 Apr 2014 22:42:32 +1000
Message-ID: <CAEgOgz4m68AdDmCWmSM1Z7exe2N5MModp1Ra-DE3Ziq6SmLQXQ@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: [Qemu-devel] PL022 VMSD versions bump
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Cc: Markus Armbruster <armbru@redhat.com>

Hi Peter,

Im looking to do some cleanup around pl022 and I would like to use it
as my lead example of code using the new generic FIFO (as I think I
have test cases handy for it). But the VMSD description for this
device is a bit ugly as it is:

        VMSTATE_INT32(tx_fifo_head, PL022State),
        VMSTATE_INT32(rx_fifo_head, PL022State),
        VMSTATE_INT32(tx_fifo_len, PL022State),
        VMSTATE_INT32(rx_fifo_len, PL022State),
        VMSTATE_UINT16(tx_fifo[0], PL022State),
        VMSTATE_UINT16(rx_fifo[0], PL022State),
        VMSTATE_UINT16(tx_fifo[1], PL022State),
        VMSTATE_UINT16(rx_fifo[1], PL022State),
        VMSTATE_UINT16(tx_fifo[2], PL022State),
        VMSTATE_UINT16(rx_fifo[2], PL022State),
        VMSTATE_UINT16(tx_fifo[3], PL022State),
        VMSTATE_UINT16(rx_fifo[3], PL022State),
        VMSTATE_UINT16(tx_fifo[4], PL022State),
        VMSTATE_UINT16(rx_fifo[4], PL022State),
        VMSTATE_UINT16(tx_fifo[5], PL022State),
        VMSTATE_UINT16(rx_fifo[5], PL022State),
        VMSTATE_UINT16(tx_fifo[6], PL022State),
        VMSTATE_UINT16(rx_fifo[6], PL022State),
        VMSTATE_UINT16(tx_fifo[7], PL022State),
        VMSTATE_UINT16(rx_fifo[7], PL022State),

There is a way to covert to Fifo while maintaining full backwards
compat (in much the same way as I did for serial), although as you can
imagine, it will be messy. Is it worth the VMSD version bump to get it
cleaned up?

Regards,
Peter