From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1ZBr08-0006VR-MB
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 16:59:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1ZBr05-0003mu-Hx
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 16:59:00 -0400
Received: from mail-yk0-f179.google.com ([209.85.160.179]:36090)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1ZBr05-0003mo-Dp
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 16:58:57 -0400
Received: by ykdr198 with SMTP id r198so132678855ykd.3
	for <qemu-devel@nongnu.org>; Sun, 05 Jul 2015 13:58:56 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <559997FB.4030301@gmail.com>
References: <1436128000-16262-1-git-send-email-crosthwaite.peter@gmail.com>
	<559997FB.4030301@gmail.com>
Date: Sun, 5 Jul 2015 13:58:56 -0700
Message-ID: <CAEgOgz4zZmTV6EDRjS_R1LnQdG_6yePwahxbZpwbifzu3jwPBQ@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko <digetx@gmail.com> wrote:
> 05.07.2015 23:26, Peter Crosthwaite =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>
>> Hi Dmitry,
>>
>> Based on my comment earlier, this is what I came up with RE consolidatio=
n
>> of
>> those arm_mptimer code paths that were giving you problems. I have not
>> done the
>> interrupt mask fix, as that one from your series is reasonably
>> independent.
>>
>> Regards,
>> Peter
>>
>> Peter Crosthwaite (2):
>>    timer: arm_mp: Factor out timer value calculation
>>    timer: arm_mp: consolidate control and counter write logic
>>
>>   hw/timer/arm_mptimer.c | 73
>> +++++++++++++++++++++++++++++---------------------
>>   1 file changed, 42 insertions(+), 31 deletions(-)
>>
>
> Hi Peter, thanks a lot! Generally, I don't have any trouble with currentl=
y
> missed functionality, just noticed it while was hacking my NVIDIA Tegra2
> emulation pet-project and decided to contribute =3D).
>
> It looks like you are trying to duplicate what generic ptimer is already
> doing, isn't it?
>

Yes, ptimer was probably the correct way to do this in the first
place. Some of the new code structures introduced in this patch series
are directly applicable though for that conversion effort.

Regards,
Peter

> --
> Dmitry
>