From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um0ui-0002XQ-Oa for qemu-devel@nongnu.org; Mon, 10 Jun 2013 08:09:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Um0ug-0005O9-OZ for qemu-devel@nongnu.org; Mon, 10 Jun 2013 08:09:32 -0400 Received: from mail-bk0-x230.google.com ([2a00:1450:4008:c01::230]:35931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um0ug-0005Nu-I6 for qemu-devel@nongnu.org; Mon, 10 Jun 2013 08:09:30 -0400 Received: by mail-bk0-f48.google.com with SMTP id jf17so3304903bkc.35 for ; Mon, 10 Jun 2013 05:09:29 -0700 (PDT) MIME-Version: 1.0 Sender: peter.crosthwaite@petalogix.com In-Reply-To: <51B5BD52.3050906@suse.de> References: <51B5BD52.3050906@suse.de> Date: Mon, 10 Jun 2013 22:09:29 +1000 Message-ID: From: Peter Crosthwaite Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-trivial@nongnu.org, edgar.iglesias@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org Hi Andreas, On Mon, Jun 10, 2013 at 9:49 PM, Andreas F=E4rber wrote: > Am 10.06.2013 12:23, schrieb Peter Crosthwaite: >> Ping! >> >> Any objections to this one going in? perhaps even via trivial queue? > > No strong objection, but you are using an unusual 12-char indentation in > some places that you may want to check. > I use that indentation when a ? : operator continues to the next line. What indentation scheme should be used in this instance? Regards, Peter > Otherwise the cosmetic cleanup looks fine to me. > > Cheers, > Andreas > >> On Mon, Jun 3, 2013 at 3:11 PM, wrote: >>> From: Peter Crosthwaite >>> >>> Some cosmetics, refactored to use util/fifo8 for the FIFO8, then >>> factored out some common code. >>> >>> Tested as working on petalogix-ml605 machine model + Linux (has >>> coverage of serial fifo usage). >>> >>> >>> Peter Crosthwaite (3): >>> char/serial: cosmetic fixes. >>> char/serial: Use generic Fifo8 >>> char/serial: serial_ioport_write: Factor out common code >>> >>> hw/char/serial.c | 128 +++++++++++++++++++--------------------= -------- >>> include/hw/char/serial.h | 15 ++---- >>> 2 files changed, 56 insertions(+), 87 deletions(-) >>> >>> -- >>> 1.8.3.rc1.44.gb387c77.dirty >>> >> > > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg >