From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtUXD-0002YO-E4 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 22:44:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtUX8-0003mq-Af for qemu-devel@nongnu.org; Wed, 18 Dec 2013 22:44:27 -0500 Received: from mail-we0-f176.google.com ([74.125.82.176]:39480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtUX8-0003mj-4V for qemu-devel@nongnu.org; Wed, 18 Dec 2013 22:44:22 -0500 Received: by mail-we0-f176.google.com with SMTP id p61so500071wes.21 for ; Wed, 18 Dec 2013 19:44:21 -0800 (PST) MIME-Version: 1.0 Sender: peter.crosthwaite@petalogix.com In-Reply-To: <1386060535-15908-8-git-send-email-s.fedorov@samsung.com> References: <1386060535-15908-1-git-send-email-s.fedorov@samsung.com> <1386060535-15908-8-git-send-email-s.fedorov@samsung.com> Date: Thu, 19 Dec 2013 13:44:21 +1000 Message-ID: From: Peter Crosthwaite Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [RFC PATCH 07/21] target-arm: reject switching to monitor mode from non-secure state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov Cc: Peter Maydell , a.basov@samsung.com, "qemu-devel@nongnu.org Developers" , Johannes Winter On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: > > Signed-off-by: Sergey Fedorov > --- > target-arm/helper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index d4407cf..e406ec9 100644 > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -2018,12 +2018,13 @@ static int bad_mode_switch(CPUARMState *env, int mode) > case ARM_CPU_MODE_USR: > case ARM_CPU_MODE_SYS: > case ARM_CPU_MODE_SVC: > - case ARM_CPU_MODE_MON: You added this in the last patch to delete it now. I dont think you need it in prev patch for bisectability as your TZ functionality isn't online at this stage of the series, I would just revert both the addition and subtraction of this line in prev and this patches respectively. Regards, Peter > case ARM_CPU_MODE_ABT: > case ARM_CPU_MODE_UND: > case ARM_CPU_MODE_IRQ: > case ARM_CPU_MODE_FIQ: > return 0; > + case ARM_CPU_MODE_MON: > + return !arm_is_secure(env); > default: > return 1; > } > -- > 1.7.9.5 > >