From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbhwC-0004HP-SG for qemu-devel@nongnu.org; Mon, 04 Jun 2012 20:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbhwB-0000DV-1R for qemu-devel@nongnu.org; Mon, 04 Jun 2012 20:47:56 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:42541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbhwA-0000DK-QY for qemu-devel@nongnu.org; Mon, 04 Jun 2012 20:47:54 -0400 Received: by bkwj10 with SMTP id j10so4650889bkw.4 for ; Mon, 04 Jun 2012 17:47:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4F7C445D.3070807@suse.de> References: <26d832cdffc1b31cfe1aa6fa9ca50f66d6fb9f71.1333088411.git.peter.crosthwaite@petalogix.com> <4F7C445D.3070807@suse.de> Date: Tue, 5 Jun 2012 10:47:51 +1000 Message-ID: From: Peter Crosthwaite Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH v1 2/4] m25p80: initial verion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: edgar.iglesias@gmail.com, qemu-devel@nongnu.org, john.williams@petalogix.com, paul@codesourcery.com On Wed, Apr 4, 2012 at 10:53 PM, Andreas F=E4rber wrote: > Am 30.03.2012 08:37, schrieb Peter A. G. Crosthwaite: >> Added device model for m25p80 SPI flash >> >> Signed-off-by: Peter A. G. Crosthwaite >> --- >> =A0Makefile.target | =A0 =A01 + >> =A0hw/m25p80.c =A0 =A0 | =A0495 ++++++++++++++++++++++++++++++++++++++++= +++++++++++++++ >> =A02 files changed, 496 insertions(+), 0 deletions(-) >> =A0create mode 100644 hw/m25p80.c >> >> diff --git a/Makefile.target b/Makefile.target >> index 8fd3718..fcccf1b 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -321,6 +321,7 @@ obj-microblaze-y =3D petalogix_s3adsp1800_mmu.o >> =A0obj-microblaze-y +=3D petalogix_ml605_mmu.o >> =A0obj-microblaze-y +=3D microblaze_boot.o >> =A0obj-microblaze-y +=3D spi.o >> +obj-microblaze-y +=3D m25p80.o >> >> =A0obj-microblaze-y +=3D microblaze_pic_cpu.o >> =A0obj-microblaze-y +=3D xilinx_intc.o >> diff --git a/hw/m25p80.c b/hw/m25p80.c >> new file mode 100644 >> index 0000000..2b67375 >> --- /dev/null >> +++ b/hw/m25p80.c >> @@ -0,0 +1,495 @@ >> +/* >> + * ST M25P80 emulator. > [snip] > > A device by ST does not sound microblaze-specific and in that case, > similar to the recent Atmel maxtouch device, should go into > hw-obj-$(CONFIG_M25P80) instead so that it's compiled only once for > microblaze-softmmu and microblazeel-softmmu. > Hi Andreas, I have regenerated this series, but have not actioned this just yet. I think adding a config switch is probably not the right solution, as its just a device model. If every device model has a config switch then isnt creating everyone config process going to be excessively tedious? perhaps it can just live next to obj-y=3Dssi.o? I.E. if you have SSI, then you have m25p80. I cant think of a case where you would want SSI but need to exclude m25p80 from the build. Regards, Peter > Same for spi.o since it implements a generic bus AFAIU. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg