From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54358)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlgVZ-0001IA-Hf
	for qemu-devel@nongnu.org; Fri, 24 Apr 2015 12:31:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlgVW-0001O4-5O
	for qemu-devel@nongnu.org; Fri, 24 Apr 2015 12:31:17 -0400
Received: from mail-qk0-f173.google.com ([209.85.220.173]:33208)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1YlgVW-0001Nw-1l
	for qemu-devel@nongnu.org; Fri, 24 Apr 2015 12:31:14 -0400
Received: by qkx62 with SMTP id 62so33215871qkx.0
	for <qemu-devel@nongnu.org>; Fri, 24 Apr 2015 09:31:13 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <CAFEAcA-dS+sQAeXTsHAEPLpHB17nDWAAP5jwEF_zeoW1VQhDdw@mail.gmail.com>
References: <cover.1427108387.git.peter.crosthwaite@xilinx.com>
	<3e026b514473978a9a68cf272a24a52c30bed437.1427108387.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA-r_MHa2wxtPcH7Q_R_eCdJp0OxgBjPs8tkbDRy31uXwg@mail.gmail.com>
	<CAEgOgz43mhkasCNM7jtKqYvN=w-9MAULUZ3UoeQR9=FxgGRSNA@mail.gmail.com>
	<CAFEAcA_vzOxK=HBgLNyCMFAxQAsocsR9iDfOfPfzGMvAYu4B-A@mail.gmail.com>
	<CAFEAcA-dS+sQAeXTsHAEPLpHB17nDWAAP5jwEF_zeoW1VQhDdw@mail.gmail.com>
Date: Fri, 24 Apr 2015 09:31:13 -0700
Message-ID: <CAEgOgz6G0GihgMP8VRBGA-dbjp2Bmww0wpro3e3piQx1PygW+A@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH target-arm v4 04/16] arm: Introduce Xilinx
 ZynqMP SoC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Ryota Ozaki <ozaki.ryota@gmail.com>, "michals@xilinx.com" <michals@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, zach.pfeffer@xilinx.com

On Fri, Apr 24, 2015 at 8:26 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 23 April 2015 at 22:38, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 23 April 2015 at 20:21, Peter Crosthwaite
>> <peter.crosthwaite@xilinx.com> wrote:
>>> On Thu, Apr 23, 2015 at 10:42 AM, Peter Maydell
>>> <peter.maydell@linaro.org> wrote:
>>>> On 23 March 2015 at 11:05, Peter Crosthwaite
>>>> <peter.crosthwaite@xilinx.com> wrote:
>>>>> --- a/hw/arm/Makefile.objs
>>>>> +++ b/hw/arm/Makefile.objs
>>>>> @@ -10,3 +10,4 @@ obj-$(CONFIG_DIGIC) += digic.o
>>>>>  obj-y += omap1.o omap2.o strongarm.o
>>>>>  obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o
>>>>>  obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o
>>>>> +obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp.o
>>>>
>>>> Can this be a common-obj- ?
>>>>
>>>
>>> Seems to build fine. I'll make this change. It's inconsistent with
>>> surrounding code so I guess this is a new policy?
>>
>> Historically this makefile's objects were only built for
>> ARM targets anyway, so it didn't make much difference.
>> Now we have aarch64 it avoids building a .o twice
>
> I looked a bit more closely at this, and hw/arm is treated
> specially (the hw/$(TARGET_BASE_ARCH) directories are
> pulled in directly by Makefile.target and only for obj-y),

Yes, I discovered the same.

> so for now new object files in this directory should just be
> in obj-. I might see if we can add support for common-obj-y,
> but that's a separate patch.
>

Will keep as-is.

Regards,
Peter


> thanks
> -- PMM
>