From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH arm-devs v3 0/4] A9 global timer + mpcore trivials
Date: Fri, 29 Nov 2013 10:12:13 +1000 [thread overview]
Message-ID: <CAEgOgz76dpxzoar09ebsnzNVX_C2oZg-sYWSyYo7NNU3WT16tw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_wm_3jcQy1nmtjKo4W2-DTsxYiAD7vLTkFEZgqJGNNQg@mail.gmail.com>
On Fri, Nov 29, 2013 at 4:30 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 28 November 2013 06:19, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> Hi Peter,
>>
>> Another spin of the ARM MPCore global timer work. Patches 1 & 2 are some
>> trivial cleanup to MPCore I did along the way.
>
> I'm happy with all of these, except that I think the
> idea is that each device gets its own CONFIG_ define,
> so we should have CONFIG_A9GTIMER or something rather
> than piggybacking on CONFIG_ARM_MPTIMER.
>
Doh! I saw your comment in V2 but it slipped thorugh the cracks when I
came to actioning your review. Sorry.
> I can just fix that nit as I put these into my target-arm
> queue, assuming that nobody has any other review comments
> that demand a respin for some other reason.
>
Ill let it cool for a few days then I can respin.
Regards,
Peter
> thanks
> -- PMM
>
prev parent reply other threads:[~2013-11-29 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 6:19 [Qemu-devel] [PATCH arm-devs v3 0/4] A9 global timer + mpcore trivials Peter Crosthwaite
2013-11-28 6:19 ` [Qemu-devel] [PATCH arm-devs v3 1/4] cpu/a9mpcore: rename timerbusdev variable Peter Crosthwaite
2013-11-28 18:30 ` Peter Maydell
2013-11-28 6:20 ` [Qemu-devel] [PATCH arm-devs v3 2/4] cpu/a9mpcore: reorder operations/declarations Peter Crosthwaite
2013-11-28 18:30 ` Peter Maydell
2013-11-28 6:20 ` [Qemu-devel] [PATCH arm-devs v3 3/4] hw/timer: Introduce ARM A9 Global Timer Peter Crosthwaite
2013-11-28 6:21 ` [Qemu-devel] [PATCH arm-devs v3 4/4] cpu/a9mpcore: Add " Peter Crosthwaite
2013-11-28 18:31 ` Peter Maydell
2013-11-28 18:30 ` [Qemu-devel] [PATCH arm-devs v3 0/4] A9 global timer + mpcore trivials Peter Maydell
2013-11-29 0:12 ` Peter Crosthwaite [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEgOgz76dpxzoar09ebsnzNVX_C2oZg-sYWSyYo7NNU3WT16tw@mail.gmail.com \
--to=peter.crosthwaite@xilinx.com \
--cc=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).