From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1VmBgw-0001hL-PM
	for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:12:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1VmBgs-0003Ds-Cy
	for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:12:18 -0500
Received: from mail-wi0-f169.google.com ([209.85.212.169]:42129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1VmBgs-0003Dg-7b
	for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:12:14 -0500
Received: by mail-wi0-f169.google.com with SMTP id hm6so1510513wib.2
	for <qemu-devel@nongnu.org>; Thu, 28 Nov 2013 16:12:13 -0800 (PST)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <CAFEAcA_wm_3jcQy1nmtjKo4W2-DTsxYiAD7vLTkFEZgqJGNNQg@mail.gmail.com>
References: <cover.1385619194.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA_wm_3jcQy1nmtjKo4W2-DTsxYiAD7vLTkFEZgqJGNNQg@mail.gmail.com>
Date: Fri, 29 Nov 2013 10:12:13 +1000
Message-ID: <CAEgOgz76dpxzoar09ebsnzNVX_C2oZg-sYWSyYo7NNU3WT16tw@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH arm-devs v3 0/4] A9 global timer + mpcore
	trivials
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On Fri, Nov 29, 2013 at 4:30 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 28 November 2013 06:19, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> Hi Peter,
>>
>> Another spin of the ARM MPCore global timer work. Patches 1 & 2 are some
>> trivial cleanup to MPCore I did along the way.
>
> I'm happy with all of these, except that I think the
> idea is that each device gets its own CONFIG_ define,
> so we should have CONFIG_A9GTIMER or something rather
> than piggybacking on CONFIG_ARM_MPTIMER.
>

Doh! I saw your comment in V2 but it slipped thorugh the cracks when I
came to actioning your review. Sorry.

> I can just fix that nit as I put these into my target-arm
> queue, assuming that nobody has any other review comments
> that demand a respin for some other reason.
>

Ill let it cool for a few days then I can respin.

Regards,
Peter

> thanks
> -- PMM
>