From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57971)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1ZE1fr-0007Zu-5X
	for qemu-devel@nongnu.org; Sat, 11 Jul 2015 16:47:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1ZE1fm-00015V-6a
	for qemu-devel@nongnu.org; Sat, 11 Jul 2015 16:47:03 -0400
Received: from mail-yk0-f179.google.com ([209.85.160.179]:36027)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1ZE1fm-00015J-1v
	for qemu-devel@nongnu.org; Sat, 11 Jul 2015 16:46:58 -0400
Received: by ykay190 with SMTP id y190so11934861yka.3
	for <qemu-devel@nongnu.org>; Sat, 11 Jul 2015 13:46:57 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
Date: Sat, 11 Jul 2015 13:46:57 -0700
Message-ID: <CAEgOgz7FbShvfsz3E_QPmj-Xv8tWbkmimWO+65xrQoQH7wp7sA@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Semantics of tcg_enabled() and what it means for
	multi-arch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Hi Paolo, Richard and all,

What is the exact semantic of tcg_enabled() supposed to be and is it
ill-defined in multi-arch?

Currently, tcg_enabled is defined as:

bool tcg_enabled(void)
{
    return tcg_ctx.code_gen_buffer != NULL;
}

In the multi-arch work, the tcg_ctx is now multiple per-arch. So lets
assume that we virtualise tcg_enabled as a CPU hook. This handles a
good number of cases, where there is a sense of a current CPU to which
the tcg_enabled is being queried. All uses in target-foo are trivially
handled as they will link against their local tcg_enabled
implementation. This per-cpu approach has the added advantage of
preparing support for mixed KVM/TCG multi-arch systems.

But tcg_enabled() is used in the memory API for dirty code tracking
where there is no sense of a current tcg_ctx:

include/exec/ram_addr.h:                if (tcg_enabled()) {
include/exec/ram_addr.h:        uint8_t clients = tcg_enabled() ?
DIRTY_CLIENTS_ALL : DIRTY_CLIENTS_NOCODE;
memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;

So what is the correct logic for populating dirty_log_mask and friends
when there are 0. 1, or more TCG engines?

Regards,
Peter