From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39501)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WhvGT-0000om-FL
	for qemu-devel@nongnu.org; Wed, 07 May 2014 02:23:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WhvGN-0002ad-Bv
	for qemu-devel@nongnu.org; Wed, 07 May 2014 02:23:37 -0400
Received: from mail-vc0-f178.google.com ([209.85.220.178]:54482)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.crosthwaite@petalogix.com>) id 1WhvGN-0002aW-7g
	for qemu-devel@nongnu.org; Wed, 07 May 2014 02:23:31 -0400
Received: by mail-vc0-f178.google.com with SMTP id hu19so665382vcb.37
	for <qemu-devel@nongnu.org>; Tue, 06 May 2014 23:23:30 -0700 (PDT)
MIME-Version: 1.0
Sender: peter.crosthwaite@petalogix.com
In-Reply-To: <1399356506-5609-23-git-send-email-edgar.iglesias@gmail.com>
References: <1399356506-5609-1-git-send-email-edgar.iglesias@gmail.com>
	<1399356506-5609-23-git-send-email-edgar.iglesias@gmail.com>
Date: Wed, 7 May 2014 16:23:30 +1000
Message-ID: <CAEgOgz7JBXJHgEM5+ConDc77W5EnU84SAj50b4Rv2xawLsdyzg@mail.gmail.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v1 22/22] target-arm: A64: Register VBAR_EL3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Rob Herring <rob.herring@linaro.org>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, John Williams <john.williams@xilinx.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>

On Tue, May 6, 2014 at 4:08 PM, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
>  target-arm/helper.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 6e3f5fa..b6dac25 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -2106,6 +2106,11 @@ static const ARMCPRegInfo v8_el3_cp_reginfo[] = {
>        .type = ARM_CP_NO_MIGRATE,
>        .opc0 = 3, .opc1 = 6, .crn = 4, .crm = 0, .opc2 = 0,
>        .access = PL3_RW, .fieldoffset = offsetof(CPUARMState, banked_spsr[7]) },
> +    { .name = "VBAR_EL3", .state = ARM_CP_STATE_AA64,
> +      .opc0 = 3, .opc1 = 6, .crn = 12, .crm = 0, .opc2 = 0,
> +      .access = PL3_RW, .writefn = vbar_write,
> +      .fieldoffset = offsetof(CPUARMState, cp15.vbar_el[2]),

Same comment as P21.

Regards,
Peter

> +      .resetvalue = 0 },
>      REGINFO_SENTINEL
>  };
>
> --
> 1.8.3.2
>
>